You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "vibhatha (via GitHub)" <gi...@apache.org> on 2024/08/14 01:57:34 UTC
[PR] GH-43643: [Java] LargeListViewVector IPC Integration [arrow]
vibhatha opened a new pull request, #43681:
URL: https://github.com/apache/arrow/pull/43681
### Rationale for this change
Newly introduced `LargeListViewVector` requires the IPC integration for C Data integration tests while mainly supporting IPC format to include this type.
### What changes are included in this PR?
Includes the `JsonFileWriter` and `JsonFileReader` along with the corresponding test cases.
### Are these changes tested?
Yes, using existing tests but adding new configurations.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43643: [Java] LargeListViewVector IPC Integration [arrow]
Posted by "vibhatha (via GitHub)" <gi...@apache.org>.
vibhatha commented on code in PR #43681:
URL: https://github.com/apache/arrow/pull/43681#discussion_r1716214056
##########
java/vector/src/test/java/org/apache/arrow/vector/ipc/TestJSONFile.java:
##########
@@ -437,10 +437,18 @@ public void testRoundtripEmptyVector() throws Exception {
"list",
FieldType.nullable(ArrowType.List.INSTANCE),
Collections.singletonList(Field.nullable("items", new ArrowType.Int(32, true)))),
+ new Field(
+ "listview",
+ FieldType.nullable(ArrowType.ListView.INSTANCE),
+ Collections.singletonList(Field.nullable("items", new ArrowType.Int(32, true)))),
Review Comment:
Added a missed case when adding IPC support for `ListViewVector`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43643: [Java] LargeListViewVector IPC Integration [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #43681:
URL: https://github.com/apache/arrow/pull/43681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43643: [Java] LargeListViewVector IPC Integration [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #43681:
URL: https://github.com/apache/arrow/pull/43681#issuecomment-2289724975
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 712cfe6d84bd344cfe57a1e4c791f8a4d052c76d.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/28782462674) has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org