You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/11/27 22:11:01 UTC
Review Request 69463: Added HEARTBEAT events and calls for the
executor HTTP API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69463/
-----------------------------------------------------------
Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
Bugs: MESOS-7564
https://issues.apache.org/jira/browse/MESOS-7564
Repository: mesos
Description
-------
These new messages are meant to be backwards compatible, in that
they won't cause crashes when new executors send heartbeats to old
agents, or new agents send heartbeats to old executors. All recipients
of these heartbeats are currently expected to ignore them, as their
only purpose is to keep certain connections from being marked "stale"
by network intermediaries.
Diffs
-----
include/mesos/executor/executor.proto 1b5fa5dab6944a8649fb98447eeec7105495b879
include/mesos/v1/executor/executor.proto b2ef325cf6a72137854355d541889c7c6ae7c230
Diff: https://reviews.apache.org/r/69463/diff/1/
Testing
-------
cmake --build . --target mesos-protobufs
Thanks,
Joseph Wu
Re: Review Request 69463: Added HEARTBEAT events and calls for the
executor HTTP API.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69463/#review210916
-----------------------------------------------------------
PASS: Mesos patch 69463 was successfully built and tested.
Reviews applied: `['69463']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2655/mesos-review-69463
- Mesos Reviewbot Windows
On Nov. 27, 2018, 10:11 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69463/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2018, 10:11 p.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
>
>
> Bugs: MESOS-7564
> https://issues.apache.org/jira/browse/MESOS-7564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These new messages are meant to be backwards compatible, in that
> they won't cause crashes when new executors send heartbeats to old
> agents, or new agents send heartbeats to old executors. All recipients
> of these heartbeats are currently expected to ignore them, as their
> only purpose is to keep certain connections from being marked "stale"
> by network intermediaries.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 1b5fa5dab6944a8649fb98447eeec7105495b879
> include/mesos/v1/executor/executor.proto b2ef325cf6a72137854355d541889c7c6ae7c230
>
>
> Diff: https://reviews.apache.org/r/69463/diff/1/
>
>
> Testing
> -------
>
> cmake --build . --target mesos-protobufs
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 69463: Added HEARTBEAT events and calls for the
executor HTTP API.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69463/#review211140
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On Dec. 6, 2018, 12:15 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69463/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2018, 12:15 a.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
>
>
> Bugs: MESOS-7564
> https://issues.apache.org/jira/browse/MESOS-7564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These new messages are meant to be backwards compatible, in that
> they won't cause crashes when new executors send heartbeats to old
> agents, or new agents send heartbeats to old executors. All recipients
> of these heartbeats are currently expected to ignore them, as their
> only purpose is to keep certain connections from being marked "stale"
> by network intermediaries.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 1b5fa5dab6944a8649fb98447eeec7105495b879
> include/mesos/v1/executor/executor.proto b2ef325cf6a72137854355d541889c7c6ae7c230
>
>
> Diff: https://reviews.apache.org/r/69463/diff/2/
>
>
> Testing
> -------
>
> cmake --build . --target mesos-protobufs
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 69463: Added HEARTBEAT events and calls for the
executor HTTP API.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69463/
-----------------------------------------------------------
(Updated Dec. 5, 2018, 4:15 p.m.)
Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
Changes
-------
Fix spelling!!! :D
Bugs: MESOS-7564
https://issues.apache.org/jira/browse/MESOS-7564
Repository: mesos
Description
-------
These new messages are meant to be backwards compatible, in that
they won't cause crashes when new executors send heartbeats to old
agents, or new agents send heartbeats to old executors. All recipients
of these heartbeats are currently expected to ignore them, as their
only purpose is to keep certain connections from being marked "stale"
by network intermediaries.
Diffs (updated)
-----
include/mesos/executor/executor.proto 1b5fa5dab6944a8649fb98447eeec7105495b879
include/mesos/v1/executor/executor.proto b2ef325cf6a72137854355d541889c7c6ae7c230
Diff: https://reviews.apache.org/r/69463/diff/2/
Changes: https://reviews.apache.org/r/69463/diff/1-2/
Testing
-------
cmake --build . --target mesos-protobufs
Thanks,
Joseph Wu
Re: Review Request 69463: Added HEARTBEAT events and calls for the
executor HTTP API.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69463/#review211027
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/executor/executor.proto
Lines 70 (patched)
<https://reviews.apache.org/r/69463/#comment295877>
s/Recieved/Received/
- Greg Mann
On Nov. 27, 2018, 10:11 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69463/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2018, 10:11 p.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
>
>
> Bugs: MESOS-7564
> https://issues.apache.org/jira/browse/MESOS-7564
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These new messages are meant to be backwards compatible, in that
> they won't cause crashes when new executors send heartbeats to old
> agents, or new agents send heartbeats to old executors. All recipients
> of these heartbeats are currently expected to ignore them, as their
> only purpose is to keep certain connections from being marked "stale"
> by network intermediaries.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 1b5fa5dab6944a8649fb98447eeec7105495b879
> include/mesos/v1/executor/executor.proto b2ef325cf6a72137854355d541889c7c6ae7c230
>
>
> Diff: https://reviews.apache.org/r/69463/diff/1/
>
>
> Testing
> -------
>
> cmake --build . --target mesos-protobufs
>
>
> Thanks,
>
> Joseph Wu
>
>