You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2001/09/07 15:54:25 UTC
cvs commit: httpd-2.0/modules/experimental mod_cache.c
trawick 01/09/07 06:54:25
Modified: modules/experimental mod_cache.c
Log:
attempt to fix some issues in mod_cache found by gcc
(use of rv and date before setting them)
Revision Changes Path
1.14 +6 -1 httpd-2.0/modules/experimental/mod_cache.c
Index: mod_cache.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/experimental/mod_cache.c,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- mod_cache.c 2001/09/07 02:56:11 1.13
+++ mod_cache.c 2001/09/07 13:54:25 1.14
@@ -540,6 +540,11 @@
/* update headers */
/* remove this filter ??? */
+
+ /* XXX is this right? we must set rv to something other than OK
+ * in this path
+ */
+ rv = HTTP_NOT_MODIFIED;
}
/* pre-existing cache handle and new entity, replace entity with this one */
else {
@@ -584,8 +589,8 @@
ap_table_set(r->headers_out, "Date", dates);
ap_log_error(APLOG_MARK, APLOG_DEBUG | APLOG_NOERRNO, 0, r->server,
"cache: Added date header");
+ info->date = date;
}
- info->date = date;
/* set response_time for HTTP/1.1 age calculations */
info->response_time = now;