[GitHub] [gobblin] prasadkarkera commented on a diff in pull request #3788: [GOBBLIN-1920] Use db laundered timestamp for reminder event

["prasadkarkera (via GitHub)" <gi...@apache.org>]

prasadkarkera commented on code in PR #3788:
URL: https://github.com/apache/gobblin/pull/3788#discussion_r1336362439


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java:
##########
@@ -277,8 +277,9 @@ public static JobDataMap updatePropsInJobDataMap(JobDataMap jobDataMap,
     // Saves the following properties in jobProps to retrieve when the trigger fires
     prevJobProps.setProperty(ConfigurationKeys.SCHEDULER_EXPECTED_REMINDER_TIME_MILLIS_KEY,
         String.valueOf(getUTCTimeFromDelayPeriod(delayPeriodMillis)));
+    // We use the db laundered timestamp for the reminder to ensure consensus between hosts  
     prevJobProps.setProperty(ConfigurationKeys.SCHEDULER_PRESERVED_CONSENSUS_EVENT_TIME_MILLIS_KEY,
-        String.valueOf(triggerEventTimeMillis));

Review Comment:
   We can probably remove this from function parameter as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org