You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/10/27 07:51:53 UTC

Review Request 39678: Allow environment variables when lanuch Docker container.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39678/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-3787
    https://issues.apache.org/jira/browse/MESOS-3787


Repository: mesos


Description
-------

Allow environment variables when lanuch Docker container.


Diffs
-----

  src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb 
  src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89 

Diff: https://reviews.apache.org/r/39678/diff/


Testing
-------

Add a new test case: DockerTest.ROOT_DOCKER_RunWithEnv


Thanks,

haosdent huang


Re: Review Request 39678: Allow environment variables when lanuch Docker container.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39678/#review104149
-----------------------------------------------------------


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos ReviewBot


On Oct. 27, 2015, 6:51 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39678/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 6:51 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3787
>     https://issues.apache.org/jira/browse/MESOS-3787
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow environment variables when lanuch Docker container.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb 
>   src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89 
> 
> Diff: https://reviews.apache.org/r/39678/diff/
> 
> 
> Testing
> -------
> 
> Add a new test case: DockerTest.ROOT_DOCKER_RunWithEnv
> 
> 
> Thanks,
> 
> haosdent huang
> 
>