You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Edell Nolan (JIRA)" <ji...@apache.org> on 2009/03/12 18:45:40 UTC
[jira] Created: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Install/Un-install of a features repository through JMX Frontend
----------------------------------------------------------------
Key: SMX4KNL-239
URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
Project: ServiceMix Kernel
Issue Type: Sub-task
Reporter: Edell Nolan
Assignee: Edell Nolan
Fix For: 1.2.0
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50916#action_50916 ]
Guillaume Nodet commented on SMX4KNL-239:
-----------------------------------------
This patch looks perfect. Feel free to go ahead and commit it.
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch, SMX4KNL-239_new.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50476#action_50476 ]
Edell Nolan commented on SMX4KNL-239:
-------------------------------------
The idea here is that we can hook up the features plugin to this install/uninstall and we can then install/uninstall a features.xml file.
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edell Nolan resolved SMX4KNL-239.
---------------------------------
Resolution: Fixed
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch, SMX4KNL-239_new.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edell Nolan updated SMX4KNL-239:
--------------------------------
Attachment: SMX4KNL-239_new.patch
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch, SMX4KNL-239_new.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50480#action_50480 ]
Edell Nolan commented on SMX4KNL-239:
-------------------------------------
the patch just needs to be applied to the kernel trunk
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50920#action_50920 ]
Edell Nolan commented on SMX4KNL-239:
-------------------------------------
Committed patch - thanks!
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch, SMX4KNL-239_new.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50477#action_50477 ]
Edell Nolan commented on SMX4KNL-239:
-------------------------------------
I have done some work on this so basically in the JMX Frontend you can with the attached patch
1) Add Repository - this allows you to see what features are available and you can then install individually if you wish
2) Remove the repository
3) Go ahead and install an entire repository in one go.
4) Un-install an entire repository.
So you can end up with a list of
Available components from Available Repositories
Installed components from InstalledRepositories
Edell.
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50634#action_50634 ]
Edell Nolan commented on SMX4KNL-239:
-------------------------------------
I have uploaded a new patch with the FeaturesServiceImpl having two new methods installAllFeatures and uninstallAllFeatures
and addtional tests
The intention is for the features maven plugin to use these to do the deploy/undeploy of the features from features.xml file.
Edell.
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch, SMX4KNL-239_new.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50504#action_50504 ]
Edell Nolan commented on SMX4KNL-239:
-------------------------------------
the patch on the config.properties shouldn't of been included.
I did do an svn update before creating the patch but I needed to change the Repository completer. I will split out the FeatureRepositoryCompleter into the two as Chris mentioned.
Yes i did comment out the uninstallation in FeatureDeploymentListener on purpose - at this point the bundle has already been uninstalled so it barfs as Chris mentioned we need another way to track this.
I added the respository URI to a feature - if you have multiple repositories installed - how can you tell what repository this feature was installed from ?
A list of installed repositories was meant to give the user an easy way of just unistalling a particular repository - otherwise they have to type the maven url for it.
Its not a big deal - I can remove it from the Mbean interfaces.
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50478#action_50478 ]
Edell Nolan commented on SMX4KNL-239:
-------------------------------------
I have attached the patch and will commit it once I get some feedback. Thanks.
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50484#action_50484 ]
Guillaume Nodet commented on SMX4KNL-239:
-----------------------------------------
I have quickly reviewed the patch and have a few comments:
* the patch on {{etc/config.properties}} seems inapropriate
* the patch on completers seems is already on trunk afaik (you should svn up before creating your patch)
* did you disabled uninstallation in the FeatureDeploymentListener on purpose ?
* what is the purpose of setting the repository URI on the feature itself ? a feature is contained by a repository already
* i don't understand the need to maintain a list of installed repositories: a repository is just a list of features the why not simply saying that installing a repo installs all the features in that repo, and uninstalling a repository uninstalls all the features from a repo ? I don't really see a repository as being something installed, it's really just a list of features.
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Edell Nolan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edell Nolan updated SMX4KNL-239:
--------------------------------
Attachment: install-uninstall.patch
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMX4KNL-239) Install/Un-install of a features
repository through JMX Frontend
Posted by "Chris Custine (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50488#action_50488 ]
Chris Custine commented on SMX4KNL-239:
---------------------------------------
Some comments and addressing some of Guillaume's issues:
* The patch on the completers all seem new to me, although the @PostConstruct in ConfigurationCompleter should be harmless.
* I recommend splitting the FeatureRepositoryCompleter out into InstalledRepositoryCompleter and AvailableRepositoryCompleter or something like that because we can't really control how this gets called from the shell (so the installed boolean flag can never be used properly).
* The {{/etc/config.properties}} patch is definitely not a good idea, but it looks like that was accidentally included in the patch set?
* The uninstall bundle event handler in FeatureDeploymentListener doesn't work because the events are called *AFTER* the bundle is uninstalled, and this is according to the OSGi spec. We'll have to find another way to track those.
> Install/Un-install of a features repository through JMX Frontend
> ----------------------------------------------------------------
>
> Key: SMX4KNL-239
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-239
> Project: ServiceMix Kernel
> Issue Type: Sub-task
> Reporter: Edell Nolan
> Assignee: Edell Nolan
> Fix For: 1.2.0
>
> Attachments: install-uninstall.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.