You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Fabian Hueske (JIRA)" <ji...@apache.org> on 2017/03/21 16:40:41 UTC

[jira] [Assigned] (FLINK-6132) Remove redundant code in CliFrontend.java

     [ https://issues.apache.org/jira/browse/FLINK-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabian Hueske reassigned FLINK-6132:
------------------------------------

    Assignee: zhengcanbin

> Remove redundant code in CliFrontend.java
> -----------------------------------------
>
>                 Key: FLINK-6132
>                 URL: https://issues.apache.org/jira/browse/FLINK-6132
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>            Reporter: zhengcanbin
>            Assignee: zhengcanbin
>            Priority: Minor
>              Labels: starter
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Look at the switch case block in method parseParameters of CliFrontend.java. 
> 		// do action
> 		switch (action) {
> 			case ACTION_RUN:
> 				return CliFrontend.this.run(params);
> 			case ACTION_LIST:
> 				return list(params);
> 			case ACTION_INFO:
> 				return info(params);
> 			case ACTION_CANCEL:
> 				return cancel(params);
> 			case ACTION_STOP:
> 				return stop(params);
> 			case ACTION_SAVEPOINT:
> 				return savepoint(params);
> It's better to change the first case return clause 
> from:
>       return CliFrontend.this.run(params);
> to:
>       return run(params);



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)