You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/10 07:33:40 UTC
[GitHub] [ozone] ChenSammi opened a new pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
ChenSammi opened a new pull request #2018:
URL: https://github.com/apache/ozone/pull/2018
https://issues.apache.org/jira/browse/HDDS-4936
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-797405031
> As we cause some minor inconveniences with the `groupId` change I would prefer to change both at the same time to cause inconvenience only once.
Totally agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi edited a comment on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi edited a comment on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-810728689
> @ChenSammi I had fixed several remaining issues in your branch:
>
> * [98b6a07](https://github.com/apache/ozone/commit/98b6a07c2b5f4af2b003f68f2b4e5d2f6a27d37c) Fix IDEA run configs
>
> * [57157df](https://github.com/apache/ozone/commit/57157df34a0cd02bf14d5f66ecc8638b8902ad29) Fix ozone-manager artifact name
>
> * [2a24161](https://github.com/apache/ozone/commit/2a24161262cc12a4712225bb5bb03e4848aa3a38) Fix module names
>
> * [715a956](https://github.com/apache/ozone/commit/715a95664e9f9efd510a1545d724915abc6cc1fb) Fix GH workflow
>
> * [0f7bf9f](https://github.com/apache/ozone/commit/0f7bf9f721ce14416245153ebb23b055c773073f) Update module names in coverage.sh
>
> * [81334ed](https://github.com/apache/ozone/commit/81334ed914d7facc6b21c4cceaff597b86228f2b) Fix checkstyle
>
>
> Why did you overwrite those?
@adoroszlai , sorry, I didn't notice it's your fixes. I just thought it's part of the impact of previous master branch force push.
Would you please resubmit your comments again?
I saw you have changed some module names. It seems module name is related with module directory name. Since we don't change the module directory name in this patch, I'm not sure if new module names are applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-796544221
Current applications which depend on ozone modules, if they don't upgrade ozone module version, they need to do nothing.
If they want to upgrade ozone module version, say from 1.0.0 to 1.1.0, they have to change ozone module groupId from "org.apache.org" to "org.apache.ozone" at the same time, otherwise there will be maven module not found error.
@ayushtkn do you think it's a big problem for current user?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi closed pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi closed pull request #2018:
URL: https://github.com/apache/ozone/pull/2018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-850343589
>
>
> @ChenSammi , lets merge the change then.
Thanks @mukul1987 , would you help to approve the merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi edited a comment on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi edited a comment on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-796544221
Current applications which depend on ozone modules, if they don't upgrade ozone module version, they need to do nothing.
If they want to upgrade ozone module version, say from 1.0.0 to 1.1.0, they have to change ozone module groupId from "org.apache.org" to "org.apache.ozone" at the same time, otherwise there will be maven module not found error.
@ayushtkn do you think it will be a big problem for current user?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi edited a comment on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi edited a comment on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-810728689
> @ChenSammi I had fixed several remaining issues in your branch:
>
> * [98b6a07](https://github.com/apache/ozone/commit/98b6a07c2b5f4af2b003f68f2b4e5d2f6a27d37c) Fix IDEA run configs
>
> * [57157df](https://github.com/apache/ozone/commit/57157df34a0cd02bf14d5f66ecc8638b8902ad29) Fix ozone-manager artifact name
>
> * [2a24161](https://github.com/apache/ozone/commit/2a24161262cc12a4712225bb5bb03e4848aa3a38) Fix module names
>
> * [715a956](https://github.com/apache/ozone/commit/715a95664e9f9efd510a1545d724915abc6cc1fb) Fix GH workflow
>
> * [0f7bf9f](https://github.com/apache/ozone/commit/0f7bf9f721ce14416245153ebb23b055c773073f) Update module names in coverage.sh
>
> * [81334ed](https://github.com/apache/ozone/commit/81334ed914d7facc6b21c4cceaff597b86228f2b) Fix checkstyle
>
>
> Why did you overwrite those?
@adoroszlai , sorry, I didn't notice it's your fixes. I just thought it's part of the impact of previous master branch force push.
Would you please resubmit your comments again?
I saw you have changed some module names. It seems module name is related with module directory name. Since we don't change the module directory name in this patch, I'm not sure if new module names are applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi edited a comment on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi edited a comment on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-850059725
Hey @mukul1987 ， can we merge this PR now？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-796595650
Not sure, shouldn’t be a big problem, may be during release an explicit mention of this would be good or somewhere in the Release notes.
If you folks are convinced,Nothing blocking from my side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi edited a comment on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi edited a comment on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-811784301
> I fetched the original commits from @adoroszlai (`git fetch origin 98b6a07c2b5f4af2b003f68f2b4e5d2f6a27d37c`) and merged it back to the latest branch from @ChenSammi and finally pushed it (`git push git@github.com:ChenSammi/ozone.git HEAD:HDDS-4936`)
>
> Now it should contain all the fixes.
Thanks @elek for the help. I tried to rebase this branch with master to resolve the conflicting files, but met a lot of unexpected conflicts. So I manually applied @adoroszlai 's patche one by one. Here is the new MR https://github.com/apache/ozone/pull/2104.
Let's continue the discussion in https://github.com/apache/ozone/pull/2104.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-851119983
Thanks @adoroszlai @elek @mukul1987 for the help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-796960014
Agree with @arp7. Maybe even better send a FYI email to dev@ as this might have big impact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-810728689
> @ChenSammi I had fixed several remaining issues in your branch:
>
> * [98b6a07](https://github.com/apache/ozone/commit/98b6a07c2b5f4af2b003f68f2b4e5d2f6a27d37c) Fix IDEA run configs
>
> * [57157df](https://github.com/apache/ozone/commit/57157df34a0cd02bf14d5f66ecc8638b8902ad29) Fix ozone-manager artifact name
>
> * [2a24161](https://github.com/apache/ozone/commit/2a24161262cc12a4712225bb5bb03e4848aa3a38) Fix module names
>
> * [715a956](https://github.com/apache/ozone/commit/715a95664e9f9efd510a1545d724915abc6cc1fb) Fix GH workflow
>
> * [0f7bf9f](https://github.com/apache/ozone/commit/0f7bf9f721ce14416245153ebb23b055c773073f) Update module names in coverage.sh
>
> * [81334ed](https://github.com/apache/ozone/commit/81334ed914d7facc6b21c4cceaff597b86228f2b) Fix checkstyle
>
>
> Why did you overwrite those?
@adoroszlai , sorry, I didn't notice it's your fixes. I just thought it's part of the impact of previous master branch force push.
Would you please resubmit your comments again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-797357723
> do you mean change "hadoop-main-ozone" to "ozone", change "hadoop-hdds" to "ozone-hdds", something like these?
Yes, exactly.
Directory names and artifact names are different. Directory names are referenced only in the `<modules>` section of the parent pom files. ArtifactIds are used in other places together with `groupId`. `artifactId` can be changed without modifying the directory structure (but some direct reference to the final `hadoop-ozone-filesystem-hadoop2-1.1.0-SNAPSHOT.jar` may require update)
While directory rename affects only the developers (therefore I am fine with delay it) the artifactId should be changed in downstream projects. As we cause some minor inconveniences with the `groupId` change I would prefer to change both at the same time to cause inconvenience only once. (Can be done either in this patch or in another patch which follows this closely.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-797201045
> Thanks the patch @ChenSammi, it looks good to me.
>
> Do we plan to remove tha `hadoop-` prefixes from the `artifactId`s, too? Or in a separated patch?
@elek , do you mean change "hadoop-main-ozone" to "ozone", change "hadoop-hdds" to "ozone-hdds", something like these?
I guess it requires changing the source code directory name as long as the artifactId, which will have obvious impact on current developers. Ideally, we should replace existing "hadoop" keywords as many as possible. But I 'm not sure how big the impact is by change the artifactId and directory name. Maybe I can send out an email to the dev list to collect more feedback
as @amaliujia has suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-805429725
Uploaded a new commit to remove Keyword “Hadoop” from the artificatID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-850141601
@ChenSammi , lets merge the change then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-810980432
I fetched the original commits from @adoroszlai (`git fetch origin 98b6a07c2b5f4af2b003f68f2b4e5d2f6a27d37c`) and merged it back to the latest branch from @ChenSammi and finally pushed it (`git push git@github.com:ChenSammi/ozone.git HEAD:HDDS-4936`)
Now it should contain all the fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] arp7 commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
arp7 commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-796881630
Hi @ChenSammi, can you please keep this PR open for a few days so more people can take a look and call out any potential incompatibilities?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-797201218
> Hi @ChenSammi, can you please keep this PR open for a few days so more people can take a look and call out any potential incompatibilities?
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-808405219
@ChenSammi I had fixed several remaining issues in your branch:
* 98b6a07c2 Fix IDEA run configs
* 57157df34 Fix ozone-manager artifact name
* 2a2416126 Fix module names
* 715a95664 Fix GH workflow
* 0f7bf9f72 Update module names in coverage.sh
* 81334ed91 Fix checkstyle
Why did you overwrite those?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-850059725
@mukul1987 ， can we merge this PR now？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi merged pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi merged pull request #2018:
URL: https://github.com/apache/ozone/pull/2018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-796530296
LGTM
@ayushtkn I am thinking this change will only impact future releases. When users bump up versions, maybe change the group is ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi edited a comment on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi edited a comment on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-805429725
Uploaded a new commit to remove Keyword “Hadoop” from the artificatID.
Hi @mukul1987 , the patch is ready for test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-811784301
> I fetched the original commits from @adoroszlai (`git fetch origin 98b6a07c2b5f4af2b003f68f2b4e5d2f6a27d37c`) and merged it back to the latest branch from @ChenSammi and finally pushed it (`git push git@github.com:ChenSammi/ozone.git HEAD:HDDS-4936`)
>
> Now it should contain all the fixes.
Thanks @elek for the help. I tried to rebase this branch with master to resolve the conflicting files, but met a lot of unexpected conflicts. So I manually applied @adoroszlai 's patche one by one. Here is the new MR https://github.com/apache/ozone/pull/2104.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-796071759
I left a question in the JIRA for more context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on pull request #2018: HDDS-4936. Change ozone groupId from org.apache.hadoop to org.apache.ozone
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #2018:
URL: https://github.com/apache/ozone/pull/2018#issuecomment-796445540
@ChenSammi is this change going to break any older application codes which have any of the ozone modules as dependency due to this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org