[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3658: TP - delivery service form layout redesign

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #3658: TP - delivery service form layout redesign
URL: https://github.com/apache/trafficcontrol/pull/3658#discussion_r292022552
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js
 ##########
 @@ -62,7 +68,7 @@ var FormDeliveryServiceController = function(deliveryService, dsCurrent, origin,
         var urlString = '';
         if (_.isArray(ds.exampleURLs) && ds.exampleURLs.length > 0) {
             for (var i = 0; i < ds.exampleURLs.length; i++) {
-                urlString += ds.exampleURLs[i] + '\n';
+                urlString += ds.exampleURLs[i] + '<br>';
             }
         }
 
 Review comment:
   Maybe this isn't the time to change this, but you can do this whole loop thing in one line:
   
   ```js
   const URLstring = ds.exampleURLs.join('<br/>');
   ```
   which has the added benefit of not including a trailing `<br>`. Unless you want that, in which case you can append it with `+` on that same line. But that shouldn't be necessary, because paragraphs should force a line break between them anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services