You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Craig Russell (JIRA)" <ji...@apache.org> on 2006/03/11 20:24:54 UTC

[jira] Created: (JDO-336) JPOX metadata query defaults unmodifiable to true; the default should be false

JPOX metadata query defaults unmodifiable to true; the default should be false
------------------------------------------------------------------------------

         Key: JDO-336
         URL: http://issues.apache.org/jira/browse/JDO-336
     Project: JDO
        Type: Bug
  Components: tck20  
    Versions: JDO 2 rc1    
 Environment: JPOX
    Reporter: Craig Russell
 Assigned to: Erik Bengtson 
     Fix For: JDO 2 final


The default for the unmodifiable attribute in queries defined in metadata is false. It was true during early development of the specification.

This causes:
    [java] 1) testPositive(org.apache.jdo.tck.query.api.ChangeQuery)javax.jdo.JDOUserException: This query is in an unmodifiable state. It's structure cannot be changed
    [java]      at org.jpox.store.query.Query.assertIsUnmodifiable(Query.java:703)
    [java]      at org.jpox.store.query.Query.setResult(Query.java:600)
    [java]      at org.apache.jdo.tck.query.api.ChangeQuery.testPositive(ChangeQuery.java:64)
    [java]      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    [java]      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    [java]      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    [java]      at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:216)
    [java]      at org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:120)
    [java]      at org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:95)
 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (JDO-336) JPOX metadata query defaults unmodifiable to true; the default should be false

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-336?page=all ]
     
Craig Russell resolved JDO-336:
-------------------------------

    Resolution: Fixed

The latest JPOX SNAPSHOT resolves this issue.

> JPOX metadata query defaults unmodifiable to true; the default should be false
> ------------------------------------------------------------------------------
>
>          Key: JDO-336
>          URL: http://issues.apache.org/jira/browse/JDO-336
>      Project: JDO
>         Type: Bug
>   Components: tck20
>     Versions: JDO 2 rc1
>  Environment: JPOX
>     Reporter: Craig Russell
>     Assignee: Erik Bengtson
>      Fix For: JDO 2 final
>  Attachments: Queryunmodifiable.patch, unmodifiable.patch
>
> The default for the unmodifiable attribute in queries defined in metadata is false. It was true during early development of the specification.
> This causes:
>     [java] 1) testPositive(org.apache.jdo.tck.query.api.ChangeQuery)javax.jdo.JDOUserException: This query is in an unmodifiable state. It's structure cannot be changed
>     [java]      at org.jpox.store.query.Query.assertIsUnmodifiable(Query.java:703)
>     [java]      at org.jpox.store.query.Query.setResult(Query.java:600)
>     [java]      at org.apache.jdo.tck.query.api.ChangeQuery.testPositive(ChangeQuery.java:64)
>     [java]      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     [java]      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>     [java]      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>     [java]      at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:216)
>     [java]      at org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:120)
>     [java]      at org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:95)
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (JDO-336) JPOX metadata query defaults unmodifiable to true; the default should be false

Posted by "Erik Bengtson (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/JDO-336?page=comments#action_12370023 ] 

Erik Bengtson commented on JDO-336:
-----------------------------------

patch applied. thx

> JPOX metadata query defaults unmodifiable to true; the default should be false
> ------------------------------------------------------------------------------
>
>          Key: JDO-336
>          URL: http://issues.apache.org/jira/browse/JDO-336
>      Project: JDO
>         Type: Bug
>   Components: tck20
>     Versions: JDO 2 rc1
>  Environment: JPOX
>     Reporter: Craig Russell
>     Assignee: Erik Bengtson
>      Fix For: JDO 2 final
>  Attachments: unmodifiable.patch
>
> The default for the unmodifiable attribute in queries defined in metadata is false. It was true during early development of the specification.
> This causes:
>     [java] 1) testPositive(org.apache.jdo.tck.query.api.ChangeQuery)javax.jdo.JDOUserException: This query is in an unmodifiable state. It's structure cannot be changed
>     [java]      at org.jpox.store.query.Query.assertIsUnmodifiable(Query.java:703)
>     [java]      at org.jpox.store.query.Query.setResult(Query.java:600)
>     [java]      at org.apache.jdo.tck.query.api.ChangeQuery.testPositive(ChangeQuery.java:64)
>     [java]      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     [java]      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>     [java]      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>     [java]      at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:216)
>     [java]      at org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:120)
>     [java]      at org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:95)
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (JDO-336) JPOX metadata query defaults unmodifiable to true; the default should be false

Posted by "Erik Bengtson (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/JDO-336?page=comments#action_12370025 ] 

Erik Bengtson commented on JDO-336:
-----------------------------------

patch applied to JPOX CVS. thx

> JPOX metadata query defaults unmodifiable to true; the default should be false
> ------------------------------------------------------------------------------
>
>          Key: JDO-336
>          URL: http://issues.apache.org/jira/browse/JDO-336
>      Project: JDO
>         Type: Bug
>   Components: tck20
>     Versions: JDO 2 rc1
>  Environment: JPOX
>     Reporter: Craig Russell
>     Assignee: Erik Bengtson
>      Fix For: JDO 2 final
>  Attachments: Queryunmodifiable.patch, unmodifiable.patch
>
> The default for the unmodifiable attribute in queries defined in metadata is false. It was true during early development of the specification.
> This causes:
>     [java] 1) testPositive(org.apache.jdo.tck.query.api.ChangeQuery)javax.jdo.JDOUserException: This query is in an unmodifiable state. It's structure cannot be changed
>     [java]      at org.jpox.store.query.Query.assertIsUnmodifiable(Query.java:703)
>     [java]      at org.jpox.store.query.Query.setResult(Query.java:600)
>     [java]      at org.apache.jdo.tck.query.api.ChangeQuery.testPositive(ChangeQuery.java:64)
>     [java]      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     [java]      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>     [java]      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>     [java]      at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:216)
>     [java]      at org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:120)
>     [java]      at org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:95)
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (JDO-336) JPOX metadata query defaults unmodifiable to true; the default should be false

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-336?page=all ]

Craig Russell updated JDO-336:
------------------------------

    Attachment: unmodifiable.patch

This patch is for QueryMetaData. It changes the default for unmodifiable to false from true.

> JPOX metadata query defaults unmodifiable to true; the default should be false
> ------------------------------------------------------------------------------
>
>          Key: JDO-336
>          URL: http://issues.apache.org/jira/browse/JDO-336
>      Project: JDO
>         Type: Bug
>   Components: tck20
>     Versions: JDO 2 rc1
>  Environment: JPOX
>     Reporter: Craig Russell
>     Assignee: Erik Bengtson
>      Fix For: JDO 2 final
>  Attachments: unmodifiable.patch
>
> The default for the unmodifiable attribute in queries defined in metadata is false. It was true during early development of the specification.
> This causes:
>     [java] 1) testPositive(org.apache.jdo.tck.query.api.ChangeQuery)javax.jdo.JDOUserException: This query is in an unmodifiable state. It's structure cannot be changed
>     [java]      at org.jpox.store.query.Query.assertIsUnmodifiable(Query.java:703)
>     [java]      at org.jpox.store.query.Query.setResult(Query.java:600)
>     [java]      at org.apache.jdo.tck.query.api.ChangeQuery.testPositive(ChangeQuery.java:64)
>     [java]      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     [java]      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>     [java]      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>     [java]      at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:216)
>     [java]      at org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:120)
>     [java]      at org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:95)
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (JDO-336) JPOX metadata query defaults unmodifiable to true; the default should be false

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JDO-336?page=all ]

Craig Russell updated JDO-336:
------------------------------

    Attachment: Queryunmodifiable.patch

This patch is for org/jpox/store/query/Query.java. It changes the method name assertIsUnmodifiable to assertIsModifiable to match the semantics of the flag.

The method name was confusing in the stack trace.

> JPOX metadata query defaults unmodifiable to true; the default should be false
> ------------------------------------------------------------------------------
>
>          Key: JDO-336
>          URL: http://issues.apache.org/jira/browse/JDO-336
>      Project: JDO
>         Type: Bug
>   Components: tck20
>     Versions: JDO 2 rc1
>  Environment: JPOX
>     Reporter: Craig Russell
>     Assignee: Erik Bengtson
>      Fix For: JDO 2 final
>  Attachments: Queryunmodifiable.patch, unmodifiable.patch
>
> The default for the unmodifiable attribute in queries defined in metadata is false. It was true during early development of the specification.
> This causes:
>     [java] 1) testPositive(org.apache.jdo.tck.query.api.ChangeQuery)javax.jdo.JDOUserException: This query is in an unmodifiable state. It's structure cannot be changed
>     [java]      at org.jpox.store.query.Query.assertIsUnmodifiable(Query.java:703)
>     [java]      at org.jpox.store.query.Query.setResult(Query.java:600)
>     [java]      at org.apache.jdo.tck.query.api.ChangeQuery.testPositive(ChangeQuery.java:64)
>     [java]      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     [java]      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>     [java]      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>     [java]      at org.apache.jdo.tck.JDO_Test.runBare(JDO_Test.java:216)
>     [java]      at org.apache.jdo.tck.util.BatchTestRunner.start(BatchTestRunner.java:120)
>     [java]      at org.apache.jdo.tck.util.BatchTestRunner.main(BatchTestRunner.java:95)
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira