You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aIbrahiim (via GitHub)" <gi...@apache.org> on 2026/06/23 16:09:53 UTC
[PR] Fix bundle finalizer callbacks for SDF [beam]
aIbrahiim opened a new pull request, #39075:
URL: https://github.com/apache/beam/pull/39075
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-4791155730
R: @acrites
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-5096177009
> In general, I don't quite think this idea will work. The main reason for needing finalize id's is that Windmill can return Commit status OK before the actual results are durably persisted in the backend. So if the persistence were to fail (e.g. backend worker gets restarted) sometime after the CommitWork returned OK but before the results were persisted, we would incorrectly run the finalize callback.
>
> I agree with your analysis of the flakiness though. It looks like the tests keep trying to process the element (claiming a new offset of the restriction) up to 3000 times expecting the finalization callback to happen at least once. What's weird is, I'd expect this to be equally flaky on the (streaming) portable worker too.
@acrites Thanks for taking a look, and yeah you’re right i took a look again and yes running the callback on CommitStatus.OK is not safe. I misunderstood that OK can come back before the results are actually durable, so if persistence fails after that we could finalize too early. That’s why the finalize-id round trip exists so this approach isn’t going to fix it
Yeah I'm glad that the flakiness analysis still lines up and on the portable side, I think it’s less flaky because finalization goes through the Fn API FinalizeBundle path instead of the Windmill applied_finalize_ids best-effort echo. Also the V2 streaming ValidatesRunner suite excludes UsesBoundedSplittableParDo, so that bounded SDF finalizer test doesn’t even run there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "acrites (via GitHub)" <gi...@apache.org>.
acrites commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-5096254079
What's weird is that the FnAPI FinalizeBundle path should have the same problem - it still relies on Windmill sending best effort finalize ids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-4790295485
@damccorm @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-4790589264
R: @arunpandianp could you please take a look? FYI the tests becomes very flaky in recent weeks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-5096905838
> What's weird is that the FnAPI FinalizeBundle path should have the same problem - it still relies on Windmill sending best effort finalize ids.
Yes I think on Dataflow the Fn API FinalizeBundle path still depends on Windmill sending applied_finalize_ids, so it should have the same best-effort limitation and that part of my explanation was wrong
So I’m less sure why portable isn’t showing the same flake. Maybe the SDF execution path is different enough or maybe V2 just doesn’t run the same tests as often (e.g. bounded SDF is excluded from the V2 streaming ValidatesRunner suite). Or maybe it is flaky there too and we just haven’t noticed as much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-4791569798
currently prefer #39092 just disabling the tests at the moment, since Dataflow classic streaming runner SDF support not completed yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-4787031229
Assigning reviewers:
R: @shunping added as fallback since no labels match configuration
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-4790949471
> @aIbrahiim could you please explain a bit what was the cause of the flaky tests
Yes sure, just updated the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "acrites (via GitHub)" <gi...@apache.org>.
acrites commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-5095472509
In general, I don't quite think this idea will work. The main reason for needing finalize id's is that Windmill can return Commit status OK before the actual results are durably persisted in the backend. So if the persistence were to fail (e.g. backend worker gets restarted) sometime after the CommitWork returned OK but before the results were persisted, we would incorrectly run the finalize callback.
I agree with your analysis of the flakiness though. It looks like the tests keep trying to process the element (claiming a new offset of the restriction) up to 3000 times expecting the finalization callback to happen at least once. What's weird is, I'd expect this to be equally flaky on the (streaming) portable worker too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-4786487384
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue with bundle finalizer callbacks in the Dataflow streaming worker. By ensuring that finalize IDs are captured during the commit process and subsequently queued for application, the changes ensure that bundle finalization logic is correctly triggered upon successful work completion.
### Highlights
* **Bundle Finalizer Callbacks**: Updated the streaming worker to correctly queue and process bundle finalizer IDs from successful commits.
* **CompleteCommit Model Update**: Extended the CompleteCommit class to include finalizeIds, ensuring this information is propagated through the commit pipeline.
<details>
<summary><b>New Features</b></summary>
🧠 You can now enable **Memory** (public preview) to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-4790604770
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix bundle finalizer callbacks for SDF [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #39075:
URL: https://github.com/apache/beam/pull/39075#issuecomment-4790615833
@aIbrahiim could you please explain a bit what was the cause of the flaky tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org