You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "John Casey (JIRA)" <ji...@codehaus.org> on 2007/08/16 01:49:47 UTC

[jira] Closed: (MASSEMBLY-184) components are not interpolated - i.e., ${params} are not substituted

     [ http://jira.codehaus.org/browse/MASSEMBLY-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey closed MASSEMBLY-184.
--------------------------------

    Resolution: Fixed

Applied. Great patch, thanks.

> components are not interpolated - i.e., ${params} are not substituted
> ---------------------------------------------------------------------
>
>                 Key: MASSEMBLY-184
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-184
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>         Environment: all
>            Reporter: John J. Franey
>            Assignee: John Casey
>             Fix For: 2.2-beta-2
>
>         Attachments: CompInterpol.diff
>
>
> Components are no more than the extension of an Assembly.  As such, they ought to also be interpolated.  Why is there the current restriction that the ${param} will be replaced when it appears in an Assembly, but not if it appears in a Component?
> Without interpolating Components, it will not be possible to refactor a component out of an assembly if it contains a ${param} to be replaced.
> Attached is a diff with the code change and a test case.  The change: the call to merge components into the assembly now appears before assembly's interpolation in the DefaultAssemblyReader, not after.
> Regards,
> John

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira