You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/07/10 01:36:20 UTC

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1869: [SCB-2035]Use vertx Json and Pojo to replace own serizalization mechanism

liubao68 commented on a change in pull request #1869:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1869#discussion_r452576656



##########
File path: service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/client/ClientUtil.java
##########
@@ -41,86 +39,68 @@
 
   private static final Logger LOGGER = LoggerFactory.getLogger(ClientUtil.class);
 
-  private static ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor();
+  public static ClientUtil INSTANCE = new ClientUtil();

Review comment:
       public static field should be final. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org