You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/18 17:48:56 UTC

[GitHub] [spark] viirya opened a new pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

viirya opened a new pull request #34948:
URL: https://github.com/apache/spark/pull/34948


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   This patch proposes to upgrade log4j to 2.17.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   There is another CVE (CVE-2021-45105) found in 2.16: https://logging.apache.org/log4j/2.x/security.html. We should upgrade log4j to 2.17.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   No
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   
   Pass all tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997287796


   **[Test build #146368 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146368/testReport)** for PR 34948 at commit [`4c19791`](https://github.com/apache/spark/commit/4c1979162226ee1674a30db17efa1f1e93c761aa).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997298287


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50842/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997287394


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50840/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997309115


   Thanks @sunchao. Merging to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997299754






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997324104


   +1, LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] OneMeadow commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
OneMeadow commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-1040609396


   QQ - Is this Log4j 2.17 or 2.17.1 - Can someone clarify?  I understand 2.17 is still vulnerable. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997282982


   **[Test build #146366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146366/testReport)** for PR 34948 at commit [`86fd129`](https://github.com/apache/spark/commit/86fd129528cce29799fb1db3b7a2b55d81f37fd6).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997294813


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50840/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Niranjan-R-S commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
Niranjan-R-S commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-1000079799


   @sunchao When will a new release be created for this fix and published to pypi?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997275458


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50838/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997275451


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50838/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997281970


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146364/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997281500


   **[Test build #146364 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146364/testReport)** for PR 34948 at commit [`86fd129`](https://github.com/apache/spark/commit/86fd129528cce29799fb1db3b7a2b55d81f37fd6).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997306015


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146368/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997292413


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50842/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997294810


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50840/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997282635


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997294813


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50840/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997298841


   **[Test build #146366 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146366/testReport)** for PR 34948 at commit [`86fd129`](https://github.com/apache/spark/commit/86fd129528cce29799fb1db3b7a2b55d81f37fd6).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997299753






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997261798


   **[Test build #146364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146364/testReport)** for PR 34948 at commit [`86fd129`](https://github.com/apache/spark/commit/86fd129528cce29799fb1db3b7a2b55d81f37fd6).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997281970


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146364/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997303710


   **[Test build #146368 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146368/testReport)** for PR 34948 at commit [`4c19791`](https://github.com/apache/spark/commit/4c1979162226ee1674a30db17efa1f1e93c761aa).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997287796


   **[Test build #146368 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146368/testReport)** for PR 34948 at commit [`4c19791`](https://github.com/apache/spark/commit/4c1979162226ee1674a30db17efa1f1e93c761aa).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997275458


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50838/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] OneMeadow commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
OneMeadow commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-1040609396


   QQ - Is this Log4j 2.17 or 2.17.1 - Can someone clarify?  I understand 2.17 is still vulnerable. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-1040616211


   @OneMeadow We already have upgraded to 2.17.1 in one later PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997286898


   ah, let me update dependency manifest...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997282982


   **[Test build #146366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146366/testReport)** for PR 34948 at commit [`86fd129`](https://github.com/apache/spark/commit/86fd129528cce29799fb1db3b7a2b55d81f37fd6).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997261798






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-1040616211


   @OneMeadow We already have upgraded to 2.17.1 in one later PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-997306015


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146368/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya closed pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
viirya closed pull request #34948:
URL: https://github.com/apache/spark/pull/34948


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #34948: [SPARK-37684][BUILD] Upgrade log4j to 2.17

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34948:
URL: https://github.com/apache/spark/pull/34948#issuecomment-1000121841


   @Niranjan-R-S . Apache Spark has a release cycle and this is for Apache Spark 3.3 on 2022 April+.
   - https://spark.apache.org/versioning-policy.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org