You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Alex Parvulescu <al...@gmail.com> on 2014/07/30 15:11:45 UTC
h2 dependency still being embedded in oak-core
Hi,
I noticed that even if the h2 dependency is now included with a 'test'
scope [0], we still embed it in the jar file [1], is there a need to still
do this or was it simply forgotten?
thanks,
alex
[0]
https://github.com/apache/jackrabbit-oak/commit/74cbf1ffb40b452195e944704ecb8a63ab273c80
[1] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/pom.xml#L43
Re: h2 dependency still being embedded in oak-core
Posted by Alex Parvulescu <al...@gmail.com>.
Hi,
No emergency here, just a simple observation. I added a comment to OA-1708
to not forget about this.
thanks,
alex
On Fri, Aug 22, 2014 at 2:09 PM, Julian Reschke <ju...@gmx.de>
wrote:
> On 2014-08-22 13:37, Julian Reschke wrote:
>
>> On 2014-08-22 12:43, Julian Reschke wrote:
>>
>>> On 2014-07-31 07:56, Chetan Mehrotra wrote:
>>>
>>>> This is being tracked via OAK-1708. Julian do we still require it or
>>>> these can be removed now?
>>>> Chetan Mehrotra
>>>> ...
>>>>
>>>
>>> I think it can be removed; checking now...
>>>
>>
>> Um, no. We have unit tests that run against a h2-based persistence.
>>
>
> Ok, I take that back. The test dependency should take care of that.
> We currently use the embeds to bootstrap a oak-based application on RDBMK;
> and in the start it was easier just to include the JARs we need. We'll move
> away from this model soonish.
>
> Can this wait a bit, or do I need to fix this urgently?
>
> Best regards, Julian
>
>
>
>
>
>
>
Re: h2 dependency still being embedded in oak-core
Posted by Julian Reschke <ju...@gmx.de>.
On 2014-08-22 13:37, Julian Reschke wrote:
> On 2014-08-22 12:43, Julian Reschke wrote:
>> On 2014-07-31 07:56, Chetan Mehrotra wrote:
>>> This is being tracked via OAK-1708. Julian do we still require it or
>>> these can be removed now?
>>> Chetan Mehrotra
>>> ...
>>
>> I think it can be removed; checking now...
>
> Um, no. We have unit tests that run against a h2-based persistence.
Ok, I take that back. The test dependency should take care of that.
We currently use the embeds to bootstrap a oak-based application on
RDBMK; and in the start it was easier just to include the JARs we need.
We'll move away from this model soonish.
Can this wait a bit, or do I need to fix this urgently?
Best regards, Julian
Re: h2 dependency still being embedded in oak-core
Posted by Julian Reschke <ju...@gmx.de>.
On 2014-08-22 12:43, Julian Reschke wrote:
> On 2014-07-31 07:56, Chetan Mehrotra wrote:
>> This is being tracked via OAK-1708. Julian do we still require it or
>> these can be removed now?
>> Chetan Mehrotra
>> ...
>
> I think it can be removed; checking now...
Um, no. We have unit tests that run against a h2-based persistence.
Best regards, Julian
Re: h2 dependency still being embedded in oak-core
Posted by Julian Reschke <ju...@greenbytes.de>.
On 2014-07-31 07:56, Chetan Mehrotra wrote:
> This is being tracked via OAK-1708. Julian do we still require it or
> these can be removed now?
> Chetan Mehrotra
> ...
I think it can be removed; checking now...
Re: h2 dependency still being embedded in oak-core
Posted by Chetan Mehrotra <ch...@gmail.com>.
This is being tracked via OAK-1708. Julian do we still require it or
these can be removed now?
Chetan Mehrotra
On Wed, Jul 30, 2014 at 6:41 PM, Alex Parvulescu
<al...@gmail.com> wrote:
> Hi,
>
> I noticed that even if the h2 dependency is now included with a 'test'
> scope [0], we still embed it in the jar file [1], is there a need to still
> do this or was it simply forgotten?
>
> thanks,
> alex
>
>
> [0]
> https://github.com/apache/jackrabbit-oak/commit/74cbf1ffb40b452195e944704ecb8a63ab273c80
> [1] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/pom.xml#L43