[GitHub] [airflow] potiuk commented on pull request #20758: Avoid unintentional data loss when deleting DAGs

[GitBox <gi...@apache.org>]

potiuk commented on pull request #20758:
URL: https://github.com/apache/airflow/pull/20758#issuecomment-1008559497


   > We encountered some data loss today due to a user deleting a DAG from the UI called `project.load`, which then deleted all of the history from other DAGs called `project.load.bigquery` and `project.load.trino`, which also caused them to run unexpectedly due to the resetting of run history.
   
   Side-comment: I was almost sure that DAG_id cannot contain "." (precisely because of the subdag convention), But now I see this i not the case :). We excluded '.' for task group (for the reason task groups are also . separated) but not for the task ids:
   
   ```
   KEY_REGEX = re.compile(r'^[\w.-]+$')
   GROUP_KEY_REGEX = re.compile(r'^[\w-]+$')
   ```
   
   Nice catch.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org