You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/05 15:18:36 UTC
[GitHub] [incubator-nuttx] patacongo opened a new pull request #731: Check
return from nxsem_wait_uninterruptible()
patacongo opened a new pull request #731: Check return from nxsem_wait_uninterruptible()
URL: https://github.com/apache/incubator-nuttx/pull/731
* Resolution of Issue 619 will require multiple steps, this part of the first step in that resolution: Every call to nxsem_wait_uninterruptible() must handle the return value from nxsem_wait_uninterruptible properly. This commit is for all remaining drivers in the Atmel SAM architectures.
* Run nxstyle on the modified files.
* Correct the naming of some new functions. Several private functions were added with a name ending with _uninterruptible. That is not correct. These new functions should be named _noncancelable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis merged pull request #731: Check return
from nxsem_wait_uninterruptible()
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #731: Check return from nxsem_wait_uninterruptible()
URL: https://github.com/apache/incubator-nuttx/pull/731
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #731: Check return
from nxsem_wait_uninterruptible()
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #731: Check return from nxsem_wait_uninterruptible()
URL: https://github.com/apache/incubator-nuttx/pull/731#issuecomment-609433497
NOTE:
- arch/arm/src/sama5/sam_can.c: Generates several "Mixed case identifier" complaints because definitions provided by header files that are not part of the change.
- arch/arm/src/sama5/sam_pmecc.c: Has two cases of "Mixed case identifies" result within commented out code. There are references to undefined types that might be provided by Atmel logic (Pmecc and Pmerrloc) if it were ever integrated.
Please ignore the "Mixed case identifier complaints" from these two files when considering to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services