You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2018/06/26 06:15:21 UTC
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE.VIEW SET OWNER
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10822
Change subject: IMPALA-6988: Implement ALTER TABLE.VIEW SET OWNER
......................................................................
IMPALA-6988: Implement ALTER TABLE.VIEW SET OWNER
Alter the table/view owner to either user or role.
On table/view creation, the table/view owner will be set to
the current user, which can be viewed via DESCRIBE FORMATTED
command. Having an owner information allows implementing a
feature where an owner can be given certain privileges
automatically upon a table/view creation. See IMPALA-7075.
The ALTER TABLE/VIEW SET OWNER will be useful commands for
transferring ownership (a set of owner privileges) from the
current owner to another owner.
Syntax:
ALTER TABLE table SET OWNER USER user
ALTER TABLE table SET OWNER ROLE role
ALTER VIEW view SET OWNER USER user
ALTER VIEW view SET OWNER ROLE role
Testing:
- Added new FE tests
- Added new E2E tests
Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
12 files changed, 340 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/10822/4
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Alter the table/view owner to either user or role.
On table/view creation, the table/view owner will be set to
the current user, which can be viewed via DESCRIBE FORMATTED
command. Having an owner information allows implementing a
feature where an owner can be given certain privileges
automatically upon a table/view creation. See IMPALA-7075.
The ALTER TABLE/VIEW SET OWNER will be useful commands for
transferring ownership (a set of owner privileges) from the
current owner to another owner.
Syntax:
ALTER TABLE table SET OWNER USER user
ALTER TABLE table SET OWNER ROLE role
ALTER VIEW view SET OWNER USER user
ALTER VIEW view SET OWNER ROLE role
Testing:
- Added new FE tests
- Added new E2E tests
Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
12 files changed, 340 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/10822/5
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 22:12:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Alter the table/view owner to either user or role.
On table/view creation, the table/view owner will be set to
the current user, which can be viewed via DESCRIBE FORMATTED
command. Having an owner information allows implementing a
feature where an owner can be given certain privileges
automatically upon a table/view creation. See IMPALA-7075.
The ALTER TABLE/VIEW SET OWNER will be useful commands for
transferring ownership (a set of owner privileges) from the
current owner to another owner.
Syntax:
ALTER TABLE table SET OWNER USER user
ALTER TABLE table SET OWNER ROLE role
ALTER VIEW view SET OWNER USER user
ALTER VIEW view SET OWNER ROLE role
Testing:
- Added new FE tests
- Added new E2E tests
Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
12 files changed, 335 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/10822/8
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Alter the table/view owner to either user or role.
On table/view creation, the table/view owner will be set to
the current user, which can be viewed via DESCRIBE FORMATTED
command. Having an owner information allows implementing a
feature where an owner can be given certain privileges
automatically upon a table/view creation. See IMPALA-7075.
The ALTER TABLE/VIEW SET OWNER will be useful commands for
transferring ownership (a set of owner privileges) from the
current owner to another owner.
Syntax:
ALTER TABLE table SET OWNER USER user
ALTER TABLE table SET OWNER ROLE role
ALTER VIEW view SET OWNER USER user
ALTER VIEW view SET OWNER ROLE role
Testing:
- Added new FE tests
- Added new E2E tests
Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Reviewed-on: http://gerrit.cloudera.org:8080/10822
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
12 files changed, 335 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 13
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 7:
(3 comments)
mostly nits, otherwise looks good.
http://gerrit.cloudera.org:8080/#/c/10822/7/fe/src/main/cup/sql-parser.cup
File fe/src/main/cup/sql-parser.cup:
http://gerrit.cloudera.org:8080/#/c/10822/7/fe/src/main/cup/sql-parser.cup@1136
PS7, Line 1136: ident_or_default:user
nit: move to prev. line
http://gerrit.cloudera.org:8080/#/c/10822/7/fe/src/main/cup/sql-parser.cup@1138
PS7, Line 1138: // The
Same comment as on L1107. Please factor the comment to top L1057 and refer to it from these three places as "See above for special partition clause handling".
http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py
File tests/metadata/test_ddl_base.py:
http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py@96
PS7, Line 96: _get_property
is this general purpose? should this be used when there are multiple rows per section?
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 20:53:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py
File tests/metadata/test_ddl_base.py:
http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py@96
PS7, Line 96: _get_property
> Yes, it's generic enough to get a single property value. The format is cons
ok, lets clarify in the comment that a single row is expected. better to assert it in case things change later on and we wind up depending on the order of items in these sections.
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 21:18:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Alter the table/view owner to either user or role.
On table/view creation, the table/view owner will be set to
the current user, which can be viewed via DESCRIBE FORMATTED
command. Having an owner information allows implementing a
feature where an owner can be given certain privileges
automatically upon a table/view creation. See IMPALA-7075.
The ALTER TABLE/VIEW SET OWNER will be useful commands for
transferring ownership (a set of owner privileges) from the
current owner to another owner.
Syntax:
ALTER TABLE table SET OWNER USER user
ALTER TABLE table SET OWNER ROLE role
ALTER VIEW view SET OWNER USER user
ALTER VIEW view SET OWNER ROLE role
Testing:
- Added new FE tests
- Added new E2E tests
Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
12 files changed, 336 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/10822/7
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Jun 2018 14:47:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py
File tests/metadata/test_ddl_base.py:
http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py@96
PS7, Line 96: _get_property
> ok, lets clarify in the comment that a single row is expected. better to as
there's a fair bit of repetition here from _get_properties. perhaps it would be easiest to just call it, assert a single entry, and return the key?
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 21:37:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 8:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10822/7/fe/src/main/cup/sql-parser.cup
File fe/src/main/cup/sql-parser.cup:
http://gerrit.cloudera.org:8080/#/c/10822/7/fe/src/main/cup/sql-parser.cup@1136
PS7, Line 1136: IDENT:user_id ident_or_default:user
> nit: move to prev. line
Done
http://gerrit.cloudera.org:8080/#/c/10822/7/fe/src/main/cup/sql-parser.cup@1138
PS7, Line 1138: // See
> Same comment as on L1107. Please factor the comment to top L1057 and refer
Done
http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py
File tests/metadata/test_ddl_base.py:
http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py@96
PS7, Line 96: _get_property
> is this general purpose? should this be used when there are multiple rows p
Yes, it's generic enough to get a single property value. The format is consistent for multiple row values vs single row value. It should not be used for multiple rows though.
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 8
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 21:14:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Alter the table/view owner to either user or role.
On table/view creation, the table/view owner will be set to
the current user, which can be viewed via DESCRIBE FORMATTED
command. Having an owner information allows implementing a
feature where an owner can be given certain privileges
automatically upon a table/view creation. See IMPALA-7075.
The ALTER TABLE/VIEW SET OWNER will be useful commands for
transferring ownership (a set of owner privileges) from the
current owner to another owner.
Syntax:
ALTER TABLE table SET OWNER USER user
ALTER TABLE table SET OWNER ROLE role
ALTER VIEW view SET OWNER USER user
ALTER VIEW view SET OWNER ROLE role
Testing:
- Added new FE tests
- Added new E2E tests
Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
12 files changed, 340 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/10822/10
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 10
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 7: Code-Review+1
Rebased and moved the tests from the old AuthorizationTest to the new AuthorizationStmtTest. Carry +1.
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 7
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Jun 2018 20:21:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sat, 07 Jul 2018 01:32:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Alter the table/view owner to either user or role.
On table/view creation, the table/view owner will be set to
the current user, which can be viewed via DESCRIBE FORMATTED
command. Having an owner information allows implementing a
feature where an owner can be given certain privileges
automatically upon a table/view creation. See IMPALA-7075.
The ALTER TABLE/VIEW SET OWNER will be useful commands for
transferring ownership (a set of owner privileges) from the
current owner to another owner.
Syntax:
ALTER TABLE table SET OWNER USER user
ALTER TABLE table SET OWNER ROLE role
ALTER VIEW view SET OWNER USER user
ALTER VIEW view SET OWNER ROLE role
Testing:
- Added new FE tests
- Added new E2E tests
Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewSetOwnerStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterTableSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
A fe/src/main/java/org/apache/impala/analysis/AlterViewSetOwnerStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M tests/metadata/test_ddl.py
M tests/metadata/test_ddl_base.py
12 files changed, 335 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/10822/11
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 11
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2780/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 22:14:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 12
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 22:14:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER
......................................................................
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py
File tests/metadata/test_ddl_base.py:
http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py@96
PS7, Line 96: _get_property
> there's a fair bit of repetition here from _get_properties. perhaps it woul
The format is a bit different between a single property vs a section with multiple properties.
For multiple rows (get_properties):
section,NULL,NULL
NULL,property1,val1
NULL,property2,va2
For a single row (get_property):
property1,value1,NULL
property2,value2,NULL
I updated the function name to not call it section_name but property_name instead.
--
To view, visit http://gerrit.cloudera.org:8080/10822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 10
Gerrit-Owner: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 21:49:34 +0000
Gerrit-HasComments: Yes