You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by li...@apache.org on 2014/05/14 20:18:21 UTC

svn commit: r1594660 - /hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionSeqidTransition.java

Author: liyin
Date: Wed May 14 18:18:21 2014
New Revision: 1594660

URL: http://svn.apache.org/r1594660
Log:
[HBASE-10343] Fix TestHRegionSeqidTransition

Author: rshroff

Summary:
The test would fail whenever the 2/3 region servers which are stopped
has the ROOT region server. The reason it fails it because of timeout in
relocating the ROOT region server. The locateMetaInRoot is suppose to
try to locate the META region, but in case the ROOT is moved, it takes
some time, until PFFE kicks in for that server, where is rediscovers the
root location. The flow is correct, it's just that the PFFE threshold is
60 secs, which might cause the test case to timeout in some cases.

The fix is reducing the threshold, so that PFFE kicks in faster.

Test Plan: run it 25 times. It should pass

Reviewers: manukranthk, everyoung, liyintang, daviddeng

Reviewed By: manukranthk

CC: hbase-dev@

Differential Revision: https://phabricator.fb.com/D1316334

Task ID: 4237582

Modified:
    hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionSeqidTransition.java

Modified: hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionSeqidTransition.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionSeqidTransition.java?rev=1594660&r1=1594659&r2=1594660&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionSeqidTransition.java (original)
+++ hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionSeqidTransition.java Wed May 14 18:18:21 2014
@@ -274,6 +274,10 @@ public class TestHRegionSeqidTransition 
     assertTrue(regionHLogNums[0] > 0);
     assertTrue(regionHLogNums[1] > 0);
 
+    // Set the Fast Fail threshold to a smaller value, so that we can retry the fetching the
+    // new location of the ROOT regionserver
+    TEST_UTIL.getConfiguration().setInt("hbase.client.fastfail.threshold", 10000);
+
     // check meta table
     HTable meta = new HTable(TEST_UTIL.getConfiguration(), HConstants.META_TABLE_NAME);
     Scan scan = new Scan();