You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/18 00:17:56 UTC
[GitHub] [iotdb] SpriCoder opened a new pull request, #7040: [IOTDB-4158] Extend the search of configuration of metric module.
SpriCoder opened a new pull request, #7040:
URL: https://github.com/apache/iotdb/pull/7040
See: https://issues.apache.org/jira/browse/IOTDB-4158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr commented on pull request #7040: [IOTDB-4158] Extend the search of configuration of metric module.
Posted by GitBox <gi...@apache.org>.
xingtanzjr commented on PR #7040:
URL: https://github.com/apache/iotdb/pull/7040#issuecomment-1220275872
> LGTM～
GOOD 啥...comments 都不对呢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr merged pull request #7040: [IOTDB-4158] Extend the search of configuration of metric module.
Posted by GitBox <gi...@apache.org>.
xingtanzjr merged PR #7040:
URL: https://github.com/apache/iotdb/pull/7040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #7040: [IOTDB-4158] Extend the search of configuration of metric module.
Posted by GitBox <gi...@apache.org>.
xingtanzjr commented on code in PR #7040:
URL: https://github.com/apache/iotdb/pull/7040#discussion_r949820886
##########
metrics/interface/src/main/java/org/apache/iotdb/metrics/config/MetricConfigDescriptor.java:
##########
@@ -104,9 +104,23 @@ public ReloadLevel loadHotProps() {
private String getPropsUrl() {
// first, try to get conf folder of standalone iotdb or datanode
String url = System.getProperty(MetricConstant.IOTDB_CONF, null);
+ if (url == null) {
+ // try to get conf folder from IOTDB_HOME
+ url = System.getProperty(MetricConstant.IOTDB_HOME, null);
+ if (url != null) {
+ url += File.separator + "conf";
+ }
+ }
// second, try to get conf folder of datanode
Review Comment:
datanode ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org