Re: Contributing with a Configurable Hibernate Appender - 4 David Castro can i release my work on Apache License 2.0?

[Stefano Girotti <ic...@hotpop.com>]

"Yoav Shapira" <yo...@apache.org> ha scritto nel messaggio 
news:db94f1a0606300626k7865d2d2oa5f03d33be6d653f@mail.gmail.com...
> Stefano,
> Thanks for suggesting your contribution!  We always welcome new
> contributors and their work.  See more comments inline:
>
>> http://www.entwash.org/hibernate/
> <snip />
>> so i take inspiration and made a Configurable Hibernate Appender... it's 
>> the
>> first time i develop an appender so i'm not sure of some aspect...
>
> Can you elaborate a little bit on "i take inspiration" above?
> Specifically, if you copied any parts of the entwash.org
> implementation (which is totally fine, not a crime or shame, don't
> worry about admitting it), what is the license of the original entwash
> code?
>
> The reason we ask is that code contributed to the Apache Software
> Foundation will be licensed under the Apache License (v2.0, see
> details at http://www.apache.org/licenses/), and if you're using parts
> of some existing code that's not licensed the same way, we need to ask
> the original authors for permission.

I Started trying to extend the classes i found... but then i use it as 
example on how to build a log4j appender...
i changed significally the stucture... i can say that i rewrote quite 
everything... for example i introduce a factory to build hibernate-pojos
As you can see in this newsgroup David licensed hiberlog under the LGPL.... 
on http://www.hibernate.org/97.html where all begins i don't find any 
original authors?!?!?
If  David Castro agrees i think we have no problem....

>> Wich is the best way to contribute & review my code..... I have to build
>> some (JUnit) test? open a sourceforge account/project?
>> Send it in this ng?
>
> One good way to go is to open a new enhancement request in our issue
> tracker: http://issues.apache.org/bugzilla/enter_bug.cgi?product=Log4j.
> Describe your enhancement, what you've done, and attach the code.

You mean i submit a new bug?!?!?! i have an account... but i didn't see any 
way to submit enhancement but only bug???

> Unit tests and any other information you can provide, e.g.
> documentation, are much appreciated.  Attach them to the issue in the
> issue tracker.

i'm a newbie of JUnit... what's the best way of testing a log4j appender???

>
> And thanks again!
>
> Yoav

Thank You!!! 




---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

Re: Contributing with a Configurable Hibernate Appender - 4 David Castro can i release my work on Apache License 2.0?

[Yoav Shapira <yo...@apache.org>]

Hi,

> [OT] a good plaste to start with JUnit? if i remember weel it's for "black
> box" testing while a log appender need to do some output!!!!

Google for any one of a million JUnit tutorials out there, including
on junit.org itself.  And as previously mentioned, take a look at
existing tests to see how we already test appenders.  For a low-level
library such as log4j, the distinction between black and white box
testing is blurry at best.

Yoav

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

Re: Contributing with a Configurable Hibernate Appender - 4 David Castro can i release my work on Apache License 2.0?

[Stefano Girotti <ic...@hotpop.com>]

"Yoav Shapira" <yo...@apache.org> ha scritto nel messaggio 
news:db94f1a0607041055q2225701by62d8a60bf86ec5b2@mail.gmail.com...
> Hi,
>
>> You mean i submit a new bug?!?!?! i have an account... but i didn't see 
>> any
>> way to submit enhancement but only bug???
>
> Open a "bug" and select "enhancement" under the severity field.

I open a new bug:

http://issues.apache.org/bugzilla/show_bug.cgi?id=39963

i also attached the status of my work

>
>> i'm a newbie of JUnit... what's the best way of testing a log4j 
>> appender???
>
> Look at the existing unit tests and modify one to suit your needs.
> Learning JUnit is easy and well worth your time.
>
> Yoav

[OT] a good plaste to start with JUnit? if i remember weel it's for "black 
box" testing while a log appender need to do some output!!!! 




---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

Re: Contributing with a Configurable Hibernate Appender - 4 David Castro can i release my work on Apache License 2.0?

[Yoav Shapira <yo...@apache.org>]

Hi,

> You mean i submit a new bug?!?!?! i have an account... but i didn't see any
> way to submit enhancement but only bug???

Open a "bug" and select "enhancement" under the severity field.

> i'm a newbie of JUnit... what's the best way of testing a log4j appender???

Look at the existing unit tests and modify one to suit your needs.
Learning JUnit is easy and well worth your time.

Yoav

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org