You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/04/24 16:49:35 UTC

[GitHub] [cordova-android] breautek commented on pull request #1212: breaking: fixes target sdk override

breautek commented on pull request #1212:
URL: https://github.com/apache/cordova-android/pull/1212#issuecomment-826120459


   @erisu 
   
   I made one last commit, as testing the latest changes produced a fail build locally...
   
   The change ensure the settings have proper types. For example gradle expects a number for the target SDK setting and will crash if it receives a string,
   
   but it looks like `config.json` could produce these values as strings if overridden via preferences.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org