You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/04/18 16:55:51 UTC
[jira] [Commented] (SHINDIG-1752) When the property
gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the
default post size ends up being 0 instead of using the default value
[ https://issues.apache.org/jira/browse/SHINDIG-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256619#comment-13256619 ]
jiraposter@reviews.apache.org commented on SHINDIG-1752:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4789/
-----------------------------------------------------------
Review request for shindig and Dan Dumont.
Summary
-------
If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
This addresses bug SHINDIG-1752.
https://issues.apache.org/jira/browse/SHINDIG-1752
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1326802
Diff: https://reviews.apache.org/r/4789/diff
Testing
-------
Ran unit tests
Thanks,
Ryan
> When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1752
> URL: https://issues.apache.org/jira/browse/SHINDIG-1752
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If a container.js is missing gadgets.jsonProxyUrl.maxPostSize the default post size will be 0 instead of the actual default size because ContainerConfig.getInt returns 0 when the property is missing not null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira