You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Quinn Leng <qu...@gmail.com> on 2017/07/14 00:24:28 UTC

Re: Review Request 60279: Added constructors for ObjectApprover::Object.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60279/
-----------------------------------------------------------

(Updated July 14, 2017, 12:24 a.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.


Summary (updated)
-----------------

Added constructors for ObjectApprover::Object.


Bugs: MESOS-7630
    https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description (updated)
-------

Added new constructors and updated all places where
ObjectApprover::Objects are constructed to use new
constructors.


Diffs
-----

  include/mesos/authorizer/authorizer.hpp 95cbcf3f9a962a896c9c23e961f02eb16dff36f8 
  src/common/http.cpp fdb591eccf273260902f3f695cf431f72ee3d817 
  src/master/http.cpp 175a44ce7fb5be509453c25eaa9ec29f35adba3a 
  src/slave/http.cpp 700871e1502a65b0bb1fc31219e09219dbdb5340 


Diff: https://reviews.apache.org/r/60279/diff/4/


Testing
-------

Passed "make check -j48"
Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48'


Thanks,

Quinn Leng