You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/02/05 23:20:45 UTC
[GitHub] [lucene] gsmiller opened a new pull request #651: Update github hunspell regression test to use JDK 17
gsmiller opened a new pull request #651:
URL: https://github.com/apache/lucene/pull/651
Not entirely sure how to test this outside of opening a PR with the change, so apologies if I have to iterate a bit to get this right in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #651: Update github hunspell regression test to use JDK 17
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #651:
URL: https://github.com/apache/lucene/pull/651#issuecomment-1030744281
I cherry-picked this in https://github.com/apache/lucene/pull/643 and it started to work, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta edited a comment on pull request #651: Update github hunspell regression test to use JDK 17
Posted by GitBox <gi...@apache.org>.
mocobeta edited a comment on pull request #651:
URL: https://github.com/apache/lucene/pull/651#issuecomment-1030746284
I wonder if we could create a custom composite action to share the JDK set up between workflows.
I have not tried but noticed custom action recently supports "use" to combine other actions in it. I will check if it works for us when I have spare time.
https://github.blog/changelog/2021-08-25-github-actions-reduce-duplication-with-action-composition/
Or, it could be better to have only one large CI workflow that executes all checks/tests just like we do so in the Jenkins servers, instead of multiple ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta edited a comment on pull request #651: Update github hunspell regression test to use JDK 17
Posted by GitBox <gi...@apache.org>.
mocobeta edited a comment on pull request #651:
URL: https://github.com/apache/lucene/pull/651#issuecomment-1030746284
I wonder if we could create a custom composite action to share the JDK set up between workflows.
I have not tried but noticed custom action recently supports "use" to combine other actions in it. I will check if it works for us when I have spare time.
https://github.blog/changelog/2021-08-25-github-actions-reduce-duplication-with-action-composition/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #651: Update github hunspell regression test to use JDK 17
Posted by GitBox <gi...@apache.org>.
gsmiller commented on pull request #651:
URL: https://github.com/apache/lucene/pull/651#issuecomment-1030861399
Ah, great! Thanks @mocobeta and @dweiss. I had cherry-picked this over in #644 as well but was having trouble getting the checks to actually run. Maybe there was a github delay in the checks firing or something, but it looks like eventually ran over there as well.
I'll go ahead and merge this to get hunspell checks unblocked. Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller merged pull request #651: Update github hunspell regression test to use JDK 17
Posted by GitBox <gi...@apache.org>.
gsmiller merged pull request #651:
URL: https://github.com/apache/lucene/pull/651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #651: Update github hunspell regression test to use JDK 17
Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #651:
URL: https://github.com/apache/lucene/pull/651#issuecomment-1030772672
> Or, it could be better to have only one large CI workflow that executes all checks/tests just like we do so in the Jenkins servers, instead of multiple ones.
This workflow check is specific to hunspell - I don't think it makes sense to run it for all the pull requests. Yes, some parts of these workflows could be pulled into a reusable action; I'm not too familiar with these though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #651: Update github hunspell regression test to use JDK 17
Posted by GitBox <gi...@apache.org>.
gsmiller commented on pull request #651:
URL: https://github.com/apache/lucene/pull/651#issuecomment-1030711669
Hmm, the github workflows don't seem to be running on this change. So I'm not sure if this change is working or not. Will see if I can figure it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #651: Update github hunspell regression test to use JDK 17
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #651:
URL: https://github.com/apache/lucene/pull/651#issuecomment-1030746284
I wonder we could create a custom composite action to share the JDK set up between workflows.
I have not tried but noticed custom action recently supports "use" to combine other actions in it. I will check if it works for us when I have spare time.
https://github.blog/changelog/2021-08-25-github-actions-reduce-duplication-with-action-composition/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org