[jira] [Commented] (OAK-7918) Extract checking logic from ConsistencyChecker

["Francesco Mari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697306#comment-16697306 ] 

Francesco Mari commented on OAK-7918:
-------------------------------------

The first version of the patch is an intermediate refactoring of {{ConsistencyChecker}}. I extracted the consistency check logic in {{ConsistencyCheckerTemplate}} and left {{ConsistencyChecker}} responsible for producing reporting and debugging statements. {{ConsistencyCheckerTemplate}} communicates the progress and the result of the consistency check to {{ConsistencyChecker}} through callback methods. Every test pass with the exception of {{CheckInvalidRepositoryTest#testLargeJournal}}.

> Extract checking logic from ConsistencyChecker 
> -----------------------------------------------
>
>                 Key: OAK-7918
>                 URL: https://issues.apache.org/jira/browse/OAK-7918
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>            Priority: Major
>             Fix For: 1.10
>
>         Attachments: OAK-7918-01.patch
>
>
> {{ConsistencyChecker}} mixes both the logic proper to a consistency check and reporting and debug statements. Moreover, it is not possible to retrieve programmatically the result of a consistency check, making it impossible to reuse this class in another context. The logic for a consistency check should be extracted to separate class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)