You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/05 18:33:32 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #977: Implements TLS for unaligned stacks.

xiaoxiang781216 commented on a change in pull request #977:
URL: https://github.com/apache/incubator-nuttx/pull/977#discussion_r420322277



##########
File path: arch/arm/include/tls.h
##########
@@ -97,11 +82,15 @@ static inline uint32_t up_getsp(void)
  *
  ****************************************************************************/
 
+#ifdef CONFIG_TLS_ALIGNED
 static inline FAR struct tls_info_s *up_tls_info(void)
 {
   DEBUGASSERT(!up_interrupt_context());
   return TLS_INFO((uintptr_t)up_getsp());

Review comment:
       Should we remove up_tls_info and tls.h but move up_getsp to arch.h? So tls_get_info can implement align/unalign in the common place.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org