You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/20 17:15:05 UTC
[kudu-CR] Fix flakiness of MiniKDC
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5156
to review the following change.
Change subject: Fix flakiness of MiniKDC
......................................................................
Fix flakiness of MiniKDC
We use 'lsof' to find the ephemeral port assigned to the MiniKDC, but we
weren't passing the '-P' flag which inhibits the conversion of numeric
port numbers to service names. As such, occasionally the MiniKDC would
be assigned some port which matches a named service in /etc/services and
result in lsof output like:
p934
f7
n*:mediabox
(mediabox is registered as port 46999)
This would cause the port number parsing to fail, making tests ~1%
flaky.
Passing the '-P' flag inhibits the conversion of port numbers to port
names.
Change-Id: I88c0459d4b8ce0371f7cdf5cc38879ecc8cbf5ff
---
M src/kudu/security/test/mini_kdc.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/5156/1
--
To view, visit http://gerrit.cloudera.org:8080/5156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88c0459d4b8ce0371f7cdf5cc38879ecc8cbf5ff
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] Fix flakiness of MiniKDC
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: Fix flakiness of MiniKDC
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88c0459d4b8ce0371f7cdf5cc38879ecc8cbf5ff
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Fix flakiness of MiniKDC
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix flakiness of MiniKDC
......................................................................
Fix flakiness of MiniKDC
We use 'lsof' to find the ephemeral port assigned to the MiniKDC, but we
weren't passing the '-P' flag which inhibits the conversion of numeric
port numbers to service names. As such, occasionally the MiniKDC would
be assigned some port which matches a named service in /etc/services and
result in lsof output like:
p934
f7
n*:mediabox
(mediabox is registered as port 46999)
This would cause the port number parsing to fail, making tests ~1%
flaky.
Passing the '-P' flag inhibits the conversion of port numbers to port
names.
Change-Id: I88c0459d4b8ce0371f7cdf5cc38879ecc8cbf5ff
Reviewed-on: http://gerrit.cloudera.org:8080/5156
Reviewed-by: Jordan Birdsell <jt...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/security/test/mini_kdc.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jordan Birdsell: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88c0459d4b8ce0371f7cdf5cc38879ecc8cbf5ff
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fix flakiness of MiniKDC
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: Fix flakiness of MiniKDC
......................................................................
Patch Set 1:
https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man8/lsof.8.html
--
To view, visit http://gerrit.cloudera.org:8080/5156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88c0459d4b8ce0371f7cdf5cc38879ecc8cbf5ff
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix flakiness of MiniKDC
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: Fix flakiness of MiniKDC
......................................................................
Patch Set 1:
I did on my mac (os x 10.11.6), the -P flag was there.
--
To view, visit http://gerrit.cloudera.org:8080/5156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88c0459d4b8ce0371f7cdf5cc38879ecc8cbf5ff
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix flakiness of MiniKDC
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix flakiness of MiniKDC
......................................................................
Patch Set 1:
@Jordan did you verify that this flag exists on OSX? that was one of my worries
--
To view, visit http://gerrit.cloudera.org:8080/5156
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88c0459d4b8ce0371f7cdf5cc38879ecc8cbf5ff
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No