[GitHub] [dolphinscheduler] czeming commented on a diff in pull request #9371: [Fix-9174] [Alert] Fix deduplication of alarm information

[GitBox <gi...@apache.org>]

czeming commented on code in PR #9371:
URL: https://github.com/apache/dolphinscheduler/pull/9371#discussion_r843952487


##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java:
##########
@@ -81,13 +77,27 @@ public int addAlert(Alert alert) {
      * @return update alert result
      */
     public int updateAlert(AlertStatus alertStatus, String log, int id) {
-        Alert alert = alertMapper.selectById(id);
+        Alert alert = new Alert();
+        alert.setId(id);
         alert.setAlertStatus(alertStatus);
         alert.setUpdateTime(new Date());
         alert.setLog(log);
         return alertMapper.updateById(alert);
     }
 
+    /**
+     * 生成通知签名信息
+     * @param alert 通知实体
+     * @return 签名文本

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org