You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/23 05:25:54 UTC

[GitHub] [calcite] jinxing64 commented on a change in pull request #1327: [CALCITE-3206] Better error message when param type incompatibility (…

jinxing64 commented on a change in pull request #1327: [CALCITE-3206] Better error message when param type incompatibility (…
URL: https://github.com/apache/calcite/pull/1327#discussion_r306133516
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java
 ##########
 @@ -795,6 +796,13 @@ private RexNode convertCall(
         for (RexNode expr : oldExprs) {
           exprs.add(cx.getRexBuilder().ensureType(type, expr, true));
         }
+      } else if (!SqlTypeUtil.areSameFamily(RexUtil.types(exprs))
+          && consistency != SqlOperandTypeChecker.Consistency.NONE) {
 
 Review comment:
   Yes, ~ This PR is lack of consideration, I will close it and rethink about it
   THX for comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services