You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "masonh22 (via GitHub)" <gi...@apache.org> on 2025/04/23 20:07:02 UTC

[I] Move parquet::file::metadata::reader::FooterTail to parquet::file::metadata so that it is public [arrow-rs]

masonh22 opened a new issue, #7438:
URL: https://github.com/apache/arrow-rs/issues/7438

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   -->
   `ParquetMetaDataReader::decode_footer` was deprecated in favor of `ParquetMetaDataReader::decode_footer_tail`, which returns a `Result<FooterTail>`.  `FooterTail` is declared public, but the module it's defined in is not public.  This seems to be an oversight, because it means that `FooterTail` is effectively private, making decode_footer_tail useless.
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   Move the FooterTail definition to parquet/file/metadata/mod.rs, or have that file `pub use` it.
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Move parquet::file::metadata::reader::FooterTail to parquet::file::metadata so that it is public [arrow-rs]

Posted by "masonh22 (via GitHub)" <gi...@apache.org>.
masonh22 commented on issue #7438:
URL: https://github.com/apache/arrow-rs/issues/7438#issuecomment-2825393583

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Move parquet::file::metadata::reader::FooterTail to parquet::file::metadata so that it is public [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #7438:
URL: https://github.com/apache/arrow-rs/issues/7438#issuecomment-2864295097

   `label_issue.py` automatically added labels {'parquet'} from #7440


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Move parquet::file::metadata::reader::FooterTail to parquet::file::metadata so that it is public [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #7438: Move parquet::file::metadata::reader::FooterTail to parquet::file::metadata so that it is public
URL: https://github.com/apache/arrow-rs/issues/7438


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org