You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/03/03 00:49:38 UTC

[GitHub] jixuan1989 commented on a change in pull request #82: Fix sonar bug

jixuan1989 commented on a change in pull request #82: Fix sonar bug
URL: https://github.com/apache/incubator-iotdb/pull/82#discussion_r261847511
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
 ##########
 @@ -291,37 +294,37 @@ public void updatePath() {
     preUpdatePath();
 
     // update the paths of subdirectories in the dataDir
-    if (dataDir.length() > 0 && !dataDir.endsWith(File.separator)) {
-      dataDir = dataDir + File.separatorChar;
+    if (getDataDir().length() > 0 && !getDataDir().endsWith(File.separator)) {
 
 Review comment:
   do we need use getDataDir() here? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services