You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Nicolas Raynaud (JIRA)" <ji...@apache.org> on 2008/02/25 04:51:07 UTC

[jira] Created: (WW-2508) Redirect Action Result with get parameters to the target action loses parameters

Redirect Action Result with get parameters to the target action loses parameters
--------------------------------------------------------------------------------

                 Key: WW-2508
                 URL: https://issues.apache.org/struts/browse/WW-2508
             Project: Struts 2
          Issue Type: Bug
    Affects Versions: 2.0.4
            Reporter: Nicolas Raynaud


As stated in WW-1714, passing extra parameters for the following action causes an exception since the system tries to affect them on the result itself. 
in ObjectFactory line 223, the exception is catched and swallown, but outside  the parameters loop, meaning that when a parameter raises the error, the following parameters in the iterator are ignored. 
I think the swallowing should be done inside the loop (in OgnlUtil.setProperties()), so that the remaining parameters are processed.


moreover, in OgnlUtil.setProperties() the root restauration line 79 is not in a finally() block while exception are expected, this might lead to furthers problems.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WW-2508) Redirect Action Result with get parameters to the target action loses parameters

Posted by "Don Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Don Brown resolved WW-2508.
---------------------------

    Resolution: Duplicate
      Assignee: Don Brown

Just fixed this in WW-2676

> Redirect Action Result with get parameters to the target action loses parameters
> --------------------------------------------------------------------------------
>
>                 Key: WW-2508
>                 URL: https://issues.apache.org/struts/browse/WW-2508
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.4
>            Reporter: Nicolas Raynaud
>            Assignee: Don Brown
>             Fix For: 2.1.3
>
>
> As stated in WW-1714, passing extra parameters for the following action causes an exception since the system tries to affect them on the result itself. 
> in ObjectFactory line 223, the exception is catched and swallown, but outside  the parameters loop, meaning that when a parameter raises the error, the following parameters in the iterator are ignored. 
> I think the swallowing should be done inside the loop (in OgnlUtil.setProperties()), so that the remaining parameters are processed.
> moreover, in OgnlUtil.setProperties() the root restauration line 79 is not in a finally() block while exception are expected, this might lead to furthers problems.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2508) Redirect Action Result with get parameters to the target action loses parameters

Posted by "Don Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Don Brown updated WW-2508:
--------------------------

    Fix Version/s: 2.1.3

> Redirect Action Result with get parameters to the target action loses parameters
> --------------------------------------------------------------------------------
>
>                 Key: WW-2508
>                 URL: https://issues.apache.org/struts/browse/WW-2508
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.4
>            Reporter: Nicolas Raynaud
>             Fix For: 2.1.3
>
>
> As stated in WW-1714, passing extra parameters for the following action causes an exception since the system tries to affect them on the result itself. 
> in ObjectFactory line 223, the exception is catched and swallown, but outside  the parameters loop, meaning that when a parameter raises the error, the following parameters in the iterator are ignored. 
> I think the swallowing should be done inside the loop (in OgnlUtil.setProperties()), so that the remaining parameters are processed.
> moreover, in OgnlUtil.setProperties() the root restauration line 79 is not in a finally() block while exception are expected, this might lead to furthers problems.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.