You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ma...@apache.org on 2024/11/13 08:15:28 UTC
(spark) branch master updated: [SPARK-50250][SQL] Assign appropriate error condition for `_LEGACY_ERROR_TEMP_2075`: `UNSUPPORTED_FEATURE.WRITE_FOR_BINARY_SOURCE`
This is an automated email from the ASF dual-hosted git repository.
maxgekk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 40ffdefc2e11 [SPARK-50250][SQL] Assign appropriate error condition for `_LEGACY_ERROR_TEMP_2075`: `UNSUPPORTED_FEATURE.WRITE_FOR_BINARY_SOURCE`
40ffdefc2e11 is described below
commit 40ffdefc2e11f9605e9bc84f3f8f3b57cb57f0d4
Author: Haejoon Lee <ha...@databricks.com>
AuthorDate: Wed Nov 13 09:15:13 2024 +0100
[SPARK-50250][SQL] Assign appropriate error condition for `_LEGACY_ERROR_TEMP_2075`: `UNSUPPORTED_FEATURE.WRITE_FOR_BINARY_SOURCE`
### What changes were proposed in this pull request?
This PR proposes to Integrate `_LEGACY_ERROR_TEMP_2075 ` into `UNSUPPORTED_FEATURE.WRITE_FOR_BINARY_SOURCE `
### Why are the changes needed?
To improve the error message by assigning proper error condition and SQLSTATE
### Does this PR introduce _any_ user-facing change?
No, only user-facing error message improved
### How was this patch tested?
Updated the existing tests
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #48780 from itholic/LEGACY_2075.
Lead-authored-by: Haejoon Lee <ha...@databricks.com>
Co-authored-by: Haejoon Lee <ha...@apache.org>
Signed-off-by: Max Gekk <ma...@gmail.com>
---
common/utils/src/main/resources/error/error-conditions.json | 10 +++++-----
.../org/apache/spark/sql/errors/QueryExecutionErrors.scala | 2 +-
.../datasources/binaryfile/BinaryFileFormatSuite.scala | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/common/utils/src/main/resources/error/error-conditions.json b/common/utils/src/main/resources/error/error-conditions.json
index cc31678bc1ec..b3c92a9f2b9d 100644
--- a/common/utils/src/main/resources/error/error-conditions.json
+++ b/common/utils/src/main/resources/error/error-conditions.json
@@ -5382,6 +5382,11 @@
"message" : [
"Update column nullability for MySQL and MS SQL Server."
]
+ },
+ "WRITE_FOR_BINARY_SOURCE" : {
+ "message" : [
+ "Write for the binary file data source."
+ ]
}
},
"sqlState" : "0A000"
@@ -7083,11 +7088,6 @@
"user-specified schema."
]
},
- "_LEGACY_ERROR_TEMP_2075" : {
- "message" : [
- "Write is not supported for binary file data source."
- ]
- },
"_LEGACY_ERROR_TEMP_2076" : {
"message" : [
"The length of <path> is <len>, which exceeds the max length allowed: <maxLength>."
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
index 6cf930f18dc2..0aa21a4d79c7 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
@@ -914,7 +914,7 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
}
def writeUnsupportedForBinaryFileDataSourceError(): SparkUnsupportedOperationException = {
- new SparkUnsupportedOperationException("_LEGACY_ERROR_TEMP_2075")
+ new SparkUnsupportedOperationException("UNSUPPORTED_FEATURE.WRITE_FOR_BINARY_SOURCE")
}
def fileLengthExceedsMaxLengthError(status: FileStatus, maxLength: Int): Throwable = {
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileFormatSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileFormatSuite.scala
index 387a2baa256b..62f2f2cb10a8 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileFormatSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileFormatSuite.scala
@@ -168,7 +168,7 @@ class BinaryFileFormatSuite extends QueryTest with SharedSparkSession {
.format(BINARY_FILE)
.save(s"$tmpDir/test_save")
},
- condition = "_LEGACY_ERROR_TEMP_2075",
+ condition = "UNSUPPORTED_FEATURE.WRITE_FOR_BINARY_SOURCE",
parameters = Map.empty)
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org