You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2015/04/10 14:10:06 UTC
Review Request 33076: Create widget wizard -> Metrics & Expression
page: Implement preview for the created expression
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33076/
-----------------------------------------------------------
Review request for Ambari, Andriy Babiichuk and Jaimin Jetly.
Bugs: AMBARI-10433
https://issues.apache.org/jira/browse/AMBARI-10433
Repository: ambari
Description
-------
On "Metrics and Expressions" page, preview needs to be shown.
On landing on this page, Show the widget type with no data. When any expression on the page is finalized by clicking on OK button of the expression box, fetch/poll the metrics value from the API and show it in the preview.
Diffs
-----
ambari-web/app/controllers/main/service/widgets/create/step2_controller.js d0a28b1eba61074607222d83a6411c29d144ca3e
ambari-web/app/messages.js 5233087910035a49bab7539b3fc626f087540073
ambari-web/app/mixins/common/widget_mixin.js 5ed262c1362e4912981eb749942d12598df3b705
ambari-web/app/styles/enhanced_service_dashboard.less b9a54bf1463ec64f8b30aa608484e873a4fb6341
ambari-web/app/templates.js 015761301126eb7e926e517228cb4b7ad04825eb
ambari-web/app/templates/main/service/widgets/create/expression.hbs 55a95378de62a01638875585fecbb9daf3a32faf
ambari-web/app/templates/main/service/widgets/create/step2.hbs 5b39032cf3b0822dc1d2512d9e34f31fe436a1e7
ambari-web/app/templates/main/service/widgets/create/step2_graph.hbs PRE-CREATION
ambari-web/app/templates/main/service/widgets/create/step2_number.hbs PRE-CREATION
ambari-web/app/templates/main/service/widgets/create/step2_template.hbs PRE-CREATION
ambari-web/app/templates/main/service/widgets/create/wizard.hbs 883d1534728c4ce0a2da8eb78578577f59f34856
ambari-web/app/views/common/widget/gauge_widget_view.js 46d6966a8d018e3c5dff7a40f04b71d455418577
ambari-web/app/views/common/widget/graph_widget_view.js b4409849858729b1886e4dc8ffe46457c57e4d52
ambari-web/app/views/common/widget/number_widget_view.js c0a85cb8309dd03effcc5ad05de8e1134ecd247b
ambari-web/app/views/common/widget/template_widget_view.js 62d043cc58af4563eae360bd666c1b51d9b52952
ambari-web/app/views/main/service/widgets/create/expression_view.js 9bc8427df352cd4f80fd5bf9e46ac4caf2f202ce
ambari-web/app/views/main/service/widgets/create/step2_view.js 0cf04a35258989ca0245e9b99f07afea09f9af70
ambari-web/app/views/main/service/widgets/create/wizard_view.js 327c5736db56ecffbe28c46e6863218a1c438550
ambari-web/test/views/main/service/widgets/create/expression_view_test.js 768bac42ad234b4a19b021f293f107efe954b335
Diff: https://reviews.apache.org/r/33076/diff/
Testing
-------
5779 tests complete (11 seconds)
78 tests pending
Thanks,
Andrii Tkach
Re: Review Request 33076: Create widget wizard -> Metrics &
Expression page: Implement preview for the created expression
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33076/#review79673
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Апрель 10, 2015, 12:10 п.п., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33076/
> -----------------------------------------------------------
>
> (Updated Апрель 10, 2015, 12:10 п.п.)
>
>
> Review request for Ambari, Andriy Babiichuk and Jaimin Jetly.
>
>
> Bugs: AMBARI-10433
> https://issues.apache.org/jira/browse/AMBARI-10433
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On "Metrics and Expressions" page, preview needs to be shown.
> On landing on this page, Show the widget type with no data. When any expression on the page is finalized by clicking on OK button of the expression box, fetch/poll the metrics value from the API and show it in the preview.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/widgets/create/step2_controller.js d0a28b1eba61074607222d83a6411c29d144ca3e
> ambari-web/app/messages.js 5233087910035a49bab7539b3fc626f087540073
> ambari-web/app/mixins/common/widget_mixin.js 5ed262c1362e4912981eb749942d12598df3b705
> ambari-web/app/styles/enhanced_service_dashboard.less b9a54bf1463ec64f8b30aa608484e873a4fb6341
> ambari-web/app/templates.js 015761301126eb7e926e517228cb4b7ad04825eb
> ambari-web/app/templates/main/service/widgets/create/expression.hbs 55a95378de62a01638875585fecbb9daf3a32faf
> ambari-web/app/templates/main/service/widgets/create/step2.hbs 5b39032cf3b0822dc1d2512d9e34f31fe436a1e7
> ambari-web/app/templates/main/service/widgets/create/step2_graph.hbs PRE-CREATION
> ambari-web/app/templates/main/service/widgets/create/step2_number.hbs PRE-CREATION
> ambari-web/app/templates/main/service/widgets/create/step2_template.hbs PRE-CREATION
> ambari-web/app/templates/main/service/widgets/create/wizard.hbs 883d1534728c4ce0a2da8eb78578577f59f34856
> ambari-web/app/views/common/widget/gauge_widget_view.js 46d6966a8d018e3c5dff7a40f04b71d455418577
> ambari-web/app/views/common/widget/graph_widget_view.js b4409849858729b1886e4dc8ffe46457c57e4d52
> ambari-web/app/views/common/widget/number_widget_view.js c0a85cb8309dd03effcc5ad05de8e1134ecd247b
> ambari-web/app/views/common/widget/template_widget_view.js 62d043cc58af4563eae360bd666c1b51d9b52952
> ambari-web/app/views/main/service/widgets/create/expression_view.js 9bc8427df352cd4f80fd5bf9e46ac4caf2f202ce
> ambari-web/app/views/main/service/widgets/create/step2_view.js 0cf04a35258989ca0245e9b99f07afea09f9af70
> ambari-web/app/views/main/service/widgets/create/wizard_view.js 327c5736db56ecffbe28c46e6863218a1c438550
> ambari-web/test/views/main/service/widgets/create/expression_view_test.js 768bac42ad234b4a19b021f293f107efe954b335
>
> Diff: https://reviews.apache.org/r/33076/diff/
>
>
> Testing
> -------
>
> 5779 tests complete (11 seconds)
> 78 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>