You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/09/01 20:29:00 UTC
[GitHub] [yunikorn-k8shim] mitdesai opened a new pull request, #458: [YUNIKORN-1273] Add configurable option to have unique application ids in a namespace
mitdesai opened a new pull request, #458:
URL: https://github.com/apache/yunikorn-k8shim/pull/458
### What is this PR for?
Ability to configure autogenerated application ids. Currently if the app id is not specified, yunikorn generates the application id with the name 'yunikorn-<name_space>-autogen' and all the pods with no application id are bundled under that name. This change adds an option to have unique auto-generated names. Appends timestamp after the namespace name to make it unique.
By default this option is not enabled and will be only turned on for specific use-cases where the user requires it.
### What type of PR is it?
- Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1273
### How should this be tested?
During deployment, change the value of environment variable 'ENABLE_AUTOGEN_UNIQUE_APP_ID' in the admission-controller.yaml to 'true'. For any apps that are scheduled without app id, should get unique application id in the following format: <namespace>_<timestamp>. eg: if namespace is default, app id will be 'default_1662060985351413000'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit commented on pull request #458: [YUNIKORN-1273] Add configurable option to have unique application ids in a namespace
Posted by GitBox <gi...@apache.org>.
craigcondit commented on PR #458:
URL: https://github.com/apache/yunikorn-k8shim/pull/458#issuecomment-1234749566
Before we consider a PR, we should really have a design document (along with motivations) uploaded to the main JIRA. There were many reasons we moved away from supporting autogenerated IDs, and we need to have a discussion around why bringing this back is needed or desired. For now, I'm going to mark the PR as "draft" until that happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit commented on pull request #458: [YUNIKORN-1273] Add configurable option to have unique application ids in a namespace
Posted by GitBox <gi...@apache.org>.
craigcondit commented on PR #458:
URL: https://github.com/apache/yunikorn-k8shim/pull/458#issuecomment-1234751730
Actually, closing this as it will need to be (eventually) targeted to the `master` branch, not `branch-1.1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #458: [YUNIKORN-1273] Add configurable option to have unique application ids in a namespace
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #458: [YUNIKORN-1273] Add configurable option to have unique application ids in a namespace
URL: https://github.com/apache/yunikorn-k8shim/pull/458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org