You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/16 03:54:32 UTC
[GitHub] [kafka] showuon opened a new pull request #10328: MINOR: update the version number to 2.6.2
showuon opened a new pull request #10328:
URL: https://github.com/apache/kafka/pull/10328
update the version number to 2.6.2
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10328: MINOR: update the version number to 2.6.2
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #10328:
URL: https://github.com/apache/kafka/pull/10328#discussion_r594848320
##########
File path: docs/upgrade.html
##########
@@ -19,7 +19,7 @@
<script id="upgrade-template" type="text/x-handlebars-template">
-<h4><a id="upgrade_2_6_1" href="#upgrade_2_6_1">Upgrading to 2.6.1 from any version 0.8.x through 2.5.x</a></h4>
+<h4><a id="upgrade_2_6_2" href="#upgrade_2_6_2">Upgrading to 2.6.2 from any version 0.8.x through 2.5.x</a></h4>
Review comment:
Since the 2.6.2 release is already under way, should we just bump this straight to 2.6.3 so we're prepared for the next bugfix release (if we ever get one)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #10328: MINOR: update the version number to 2.6.2
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10328:
URL: https://github.com/apache/kafka/pull/10328#discussion_r594860616
##########
File path: docs/upgrade.html
##########
@@ -19,7 +19,7 @@
<script id="upgrade-template" type="text/x-handlebars-template">
-<h4><a id="upgrade_2_6_1" href="#upgrade_2_6_1">Upgrading to 2.6.1 from any version 0.8.x through 2.5.x</a></h4>
+<h4><a id="upgrade_2_6_2" href="#upgrade_2_6_2">Upgrading to 2.6.2 from any version 0.8.x through 2.5.x</a></h4>
Review comment:
Thanks, I just thought we missed it. If not, I'll close this PR, then.
Thank you for the V2.6.2 release. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10328: MINOR: update the version number to 2.6.2
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #10328:
URL: https://github.com/apache/kafka/pull/10328#discussion_r596417249
##########
File path: docs/upgrade.html
##########
@@ -19,7 +19,7 @@
<script id="upgrade-template" type="text/x-handlebars-template">
-<h4><a id="upgrade_2_6_1" href="#upgrade_2_6_1">Upgrading to 2.6.1 from any version 0.8.x through 2.5.x</a></h4>
+<h4><a id="upgrade_2_6_2" href="#upgrade_2_6_2">Upgrading to 2.6.2 from any version 0.8.x through 2.5.x</a></h4>
Review comment:
Noticed that the 2.8 branch was also missing this so I brought this to the 2.8 RM's attention too, thanks again for the attention to detail!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon closed pull request #10328: MINOR: update the version number to 2.6.2
Posted by GitBox <gi...@apache.org>.
showuon closed pull request #10328:
URL: https://github.com/apache/kafka/pull/10328
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10328: MINOR: update the version number to 2.6.2
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10328:
URL: https://github.com/apache/kafka/pull/10328#issuecomment-799925201
@ableegoldman , please help review. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10328: MINOR: update the version number to 2.6.2
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #10328:
URL: https://github.com/apache/kafka/pull/10328#discussion_r596412889
##########
File path: docs/upgrade.html
##########
@@ -19,7 +19,7 @@
<script id="upgrade-template" type="text/x-handlebars-template">
-<h4><a id="upgrade_2_6_1" href="#upgrade_2_6_1">Upgrading to 2.6.1 from any version 0.8.x through 2.5.x</a></h4>
+<h4><a id="upgrade_2_6_2" href="#upgrade_2_6_2">Upgrading to 2.6.2 from any version 0.8.x through 2.5.x</a></h4>
Review comment:
No worries! And actually I wasn't implying that we should close this PR, just that I'll need to do a separate one against kafka-site since the docs have already been generated for 2.6.2. If you reopen this PR I can go ahead and merge it
Once again, thanks for catching this! It looks like this has been missed before (eg the 2.5 branch still references 2.4.0 when it should be up to 2.5.1) -- guess it's easy to miss. I'll add a note to the release guide to point this out explicitly for future RMs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10328: MINOR: update the version number to 2.6.2
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #10328:
URL: https://github.com/apache/kafka/pull/10328#discussion_r594848632
##########
File path: docs/upgrade.html
##########
@@ -19,7 +19,7 @@
<script id="upgrade-template" type="text/x-handlebars-template">
-<h4><a id="upgrade_2_6_1" href="#upgrade_2_6_1">Upgrading to 2.6.1 from any version 0.8.x through 2.5.x</a></h4>
+<h4><a id="upgrade_2_6_2" href="#upgrade_2_6_2">Upgrading to 2.6.2 from any version 0.8.x through 2.5.x</a></h4>
Review comment:
The docs have already been generated for 2.6.2, so this won't get picked up unless we have to roll a new RC for some reason. How about we bump it to 2.6.3, but I'll wait until the current RC has been approved until merging this just in case -- thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org