You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/20 18:44:12 UTC

[GitHub] [arrow] westonpace commented on a change in pull request #11997: ARROW-10998: [C++] Detect URIs where a filesystem path is expected

westonpace commented on a change in pull request #11997:
URL: https://github.com/apache/arrow/pull/11997#discussion_r772587608



##########
File path: cpp/src/arrow/filesystem/s3fs.cc
##########
@@ -402,6 +402,10 @@ struct S3Path {
   std::vector<std::string> key_parts;
 
   static Result<S3Path> FromString(const std::string& s) {
+    if (internal::IsLikelyUri(s)) {
+      return Status::Invalid(
+          "Expected a S3 object path of the form 'bucket/key...', got a URI: '", s, "'");

Review comment:
       ```suggestion
             "Expected an S3 object path of the form 'bucket/key...', got a URI: '", s, "'");
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org