You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/11/01 21:45:48 UTC

Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Our upstreamed PR to the `concurrentqueue` project was merged,
(https://github.com/cameron314/concurrentqueue/commit/420509b)
which fixes the Clang / libstdc++ configuration. Since there are
a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
we bundle the latest SHA on `master` here.


Diffs
-----

  3rdparty/README.md PRE-CREATION 
  3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
  3rdparty/concurrentqueue-1.0.0-beta.tar.gz 1bf4a88362e7d60cd22474f20fff62f788539308 
  3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
  3rdparty/concurrentqueue.md PRE-CREATION 
  3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 


Diff: https://reviews.apache.org/r/63472/diff/1/


Testing
-------

With Clang-3.9.0
```bash
CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl --enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue --disable-java --disable-python
make distcheck
```


Thanks,

Michael Park


Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/#review189878
-----------------------------------------------------------


Ship it!




Mind splitting the folder level readme from the concurrent queue into separate patches? Also, a ticket about the repo bloat issue would be great.

Is it compressed with maximum compression?

- Benjamin Mahler


On Nov. 1, 2017, 9:45 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63472/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2017, 9:45 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Our upstreamed PR to the `concurrentqueue` project was merged,
> (https://github.com/cameron314/concurrentqueue/commit/420509b)
> which fixes the Clang / libstdc++ configuration. Since there are
> a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
> we bundle the latest SHA on `master` here.
> 
> 
> Diffs
> -----
> 
>   3rdparty/README.md PRE-CREATION 
>   3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
>   3rdparty/concurrentqueue-1.0.0-beta.tar.gz 1bf4a88362e7d60cd22474f20fff62f788539308 
>   3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
>   3rdparty/concurrentqueue.md PRE-CREATION 
>   3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 
> 
> 
> Diff: https://reviews.apache.org/r/63472/diff/1/
> 
> 
> Testing
> -------
> 
> With Clang-3.9.0
> ```bash
> CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl --enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue --disable-java --disable-python
> make distcheck
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/#review189876
-----------------------------------------------------------



Bad patch!

Reviews applied: [63472]

Failed command: python support/apply-reviews.py -n -r 63472

Error:
2017-11-02 04:03:28 URL:https://reviews.apache.org/r/63472/diff/raw/ [3272/3272] -> "63472.patch" [1]
error: missing binary patch data for '3rdparty/concurrentqueue-7b69a8f.tar.gz'
error: binary patch does not apply to '3rdparty/concurrentqueue-7b69a8f.tar.gz'
error: 3rdparty/concurrentqueue-7b69a8f.tar.gz: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19967/console

- Mesos Reviewbot


On Nov. 1, 2017, 2:45 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63472/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2017, 2:45 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Our upstreamed PR to the `concurrentqueue` project was merged,
> (https://github.com/cameron314/concurrentqueue/commit/420509b)
> which fixes the Clang / libstdc++ configuration. Since there are
> a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
> we bundle the latest SHA on `master` here.
> 
> 
> Diffs
> -----
> 
>   3rdparty/README.md PRE-CREATION 
>   3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
>   3rdparty/concurrentqueue-1.0.0-beta.tar.gz 1bf4a88362e7d60cd22474f20fff62f788539308 
>   3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
>   3rdparty/concurrentqueue.md PRE-CREATION 
>   3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 
> 
> 
> Diff: https://reviews.apache.org/r/63472/diff/1/
> 
> 
> Testing
> -------
> 
> With Clang-3.9.0
> ```bash
> CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl --enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue --disable-java --disable-python
> make distcheck
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/
-----------------------------------------------------------

(Updated Nov. 2, 2017, 12:45 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Took the `3rdparty/README.md` out.


Repository: mesos


Description
-------

Our upstreamed PR to the `concurrentqueue` project was merged,
(https://github.com/cameron314/concurrentqueue/commit/420509b)
which fixes the Clang / libstdc++ configuration. Since there are
a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
we bundle the latest SHA on `master` here.


Diffs (updated)
-----

  3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
  3rdparty/concurrentqueue-1.0.0-beta.tar.gz 1bf4a88362e7d60cd22474f20fff62f788539308 
  3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
  3rdparty/concurrentqueue.md PRE-CREATION 
  3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 


Diff: https://reviews.apache.org/r/63472/diff/2/

Changes: https://reviews.apache.org/r/63472/diff/1-2/


Testing
-------

With Clang-3.9.0
```bash
CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl --enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue --disable-java --disable-python
make distcheck
```
```bash
CC=clang CXX=clang++ cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DENABLE_LIBEVENT=ON -DENABLE_SSL=ON -DENABLE_LOCK_FREE_RUN_QUEUE=ON ..
cmake --build --target tests
ctest -V
```


Thanks,

Michael Park


Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/
-----------------------------------------------------------

(Updated Nov. 2, 2017, 12:44 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Tested with CMake as well.


Repository: mesos


Description
-------

Our upstreamed PR to the `concurrentqueue` project was merged,
(https://github.com/cameron314/concurrentqueue/commit/420509b)
which fixes the Clang / libstdc++ configuration. Since there are
a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
we bundle the latest SHA on `master` here.


Diffs
-----

  3rdparty/README.md PRE-CREATION 
  3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
  3rdparty/concurrentqueue-1.0.0-beta.tar.gz 1bf4a88362e7d60cd22474f20fff62f788539308 
  3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
  3rdparty/concurrentqueue.md PRE-CREATION 
  3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 


Diff: https://reviews.apache.org/r/63472/diff/1/


Testing (updated)
-------

With Clang-3.9.0
```bash
CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl --enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue --disable-java --disable-python
make distcheck
```
```bash
CC=clang CXX=clang++ cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DENABLE_LIBEVENT=ON -DENABLE_SSL=ON -DENABLE_LOCK_FREE_RUN_QUEUE=ON ..
cmake --build --target tests
ctest -V
```


Thanks,

Michael Park


Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63472/#review189853
-----------------------------------------------------------



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 63472`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63472

Relevant logs:

- [apply-review-63472-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63472/logs/apply-review-63472-stdout.log):

```
error: missing binary patch data for '3rdparty/concurrentqueue-7b69a8f.tar.gz'
error: binary patch does not apply to '3rdparty/concurrentqueue-7b69a8f.tar.gz'
error: 3rdparty/concurrentqueue-7b69a8f.tar.gz: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 1, 2017, 9:45 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63472/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2017, 9:45 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Our upstreamed PR to the `concurrentqueue` project was merged,
> (https://github.com/cameron314/concurrentqueue/commit/420509b)
> which fixes the Clang / libstdc++ configuration. Since there are
> a bunch of bug fixes committed to `master` since `v1.0.0-beta`,
> we bundle the latest SHA on `master` here.
> 
> 
> Diffs
> -----
> 
>   3rdparty/README.md PRE-CREATION 
>   3rdparty/cmake/Versions.cmake 9a6713db7f0ea535bcbbe0c44faf7afb64575169 
>   3rdparty/concurrentqueue-1.0.0-beta.tar.gz 1bf4a88362e7d60cd22474f20fff62f788539308 
>   3rdparty/concurrentqueue-7b69a8f.tar.gz PRE-CREATION 
>   3rdparty/concurrentqueue.md PRE-CREATION 
>   3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba 
> 
> 
> Diff: https://reviews.apache.org/r/63472/diff/1/
> 
> 
> Testing
> -------
> 
> With Clang-3.9.0
> ```bash
> CC=clang CXX=clang++ ../configure --enable-libevent --enable-ssl --enable-optimize --enable-lock-free-run-queue --enable-lock-free-event-queue --disable-java --disable-python
> make distcheck
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>