You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/11 09:01:33 UTC

[GitHub] [shardingsphere] lanchengx opened a new pull request, #17588: Remove the `@NoArgsConstructor` and `@Setter` annotations of `HandlerParameter`

lanchengx opened a new pull request, #17588:
URL: https://github.com/apache/shardingsphere/pull/17588

   Changes proposed in this pull request:
   - Remove the `@NoArgsConstructor` and `@Setter` annotations of `HandlerParameter`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #17588: Remove the `@NoArgsConstructor` and `@Setter` annotations of `HandlerParameter`

Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #17588:
URL: https://github.com/apache/shardingsphere/pull/17588


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #17588: Remove the `@NoArgsConstructor` and `@Setter` annotations of `HandlerParameter`

Posted by GitBox <gi...@apache.org>.
terrymanu commented on PR #17588:
URL: https://github.com/apache/shardingsphere/pull/17588#issuecomment-1124446722

   Please resolve conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lanchengx commented on pull request #17588: Remove the `@NoArgsConstructor` and `@Setter` annotations of `HandlerParameter`

Posted by GitBox <gi...@apache.org>.
lanchengx commented on PR #17588:
URL: https://github.com/apache/shardingsphere/pull/17588#issuecomment-1123398682

   All set methods are used by Test.
   In addition, regarding thread safety, will DistSQL handlers be thread-unsafe?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #17588: Remove the `@NoArgsConstructor` and `@Setter` annotations of `HandlerParameter`

Posted by GitBox <gi...@apache.org>.
terrymanu commented on code in PR #17588:
URL: https://github.com/apache/shardingsphere/pull/17588#discussion_r870111068


##########
shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/RALBackendHandler.java:
##########
@@ -73,10 +71,8 @@ public final R initStatement(final E statement) {
     }
     
     @Getter
-    @Setter
     @Accessors(chain = true)
     @AllArgsConstructor

Review Comment:
   Can it use @RequiredArgsConstructor with final field?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] lanchengx commented on pull request #17588: Remove the `@NoArgsConstructor` and `@Setter` annotations of `HandlerParameter`

Posted by GitBox <gi...@apache.org>.
lanchengx commented on PR #17588:
URL: https://github.com/apache/shardingsphere/pull/17588#issuecomment-1124803075

   > Please resolve conflicts
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org