You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2013/09/02 21:28:52 UTC

[jira] [Commented] (ISIS-502) wicket componentList order sensitivity

    [ https://issues.apache.org/jira/browse/ISIS-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756218#comment-13756218 ] 

ASF subversion and git services commented on ISIS-502:
------------------------------------------------------

Commit 518bedcd30f592d0b3c3ba7288f88eab9cfca7b8 in branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=518bedc ]

ISIS-502: patch for Jeremy Gurr

when replacing a Wicket ComponentFactory, the replacement takes the position of that replaced

Signed-off-by: Dan Haywood <da...@apache.org>

                
> wicket componentList order sensitivity
> --------------------------------------
>
>                 Key: ISIS-502
>                 URL: https://issues.apache.org/jira/browse/ISIS-502
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: Wicket
>    Affects Versions: viewer-wicket-1.3.0
>            Reporter: Jeremy Gurr
>            Assignee: Dan Haywood
>         Attachments: patch
>
>
> When replacing a component factory (IsisBlobPanelFactory, for example), it is added to the end of the component list instead of the same place it came from. Since, unfortunately, the order of these components affects which factory is chosen to render a component type, this actually changes the behavior of the app in unexpected and hard to debug ways, since a different factory now will intercept the component request. 
> I've got a patch which fixes this, basically by injecting the replacement factory into the same location in the component list, but I'm not sure how to attach it to the bug ticket. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira