You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/10 01:21:15 UTC
[GitHub] [apisix] jobop opened a new pull request, #8493: fix the bug:when the key is deleted is will throw a exception
jobop opened a new pull request, #8493:
URL: https://github.com/apache/apisix/pull/8493
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
https://github.com/apache/apisix/issues/8492
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zhangliweixyz commented on pull request #8493: fix: etcd data sync exception
Posted by GitBox <gi...@apache.org>.
zhangliweixyz commented on PR #8493:
URL: https://github.com/apache/apisix/pull/8493#issuecomment-1354149040
I had the same problem, and Is there any way to solve this problem？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jobop commented on pull request #8493: fix: etcd data sync exception
Posted by GitBox <gi...@apache.org>.
jobop commented on PR #8493:
URL: https://github.com/apache/apisix/pull/8493#issuecomment-1346694082
> Is it possible to add a test case to avoid regression? For example, we can add a test in https://github.com/apache/apisix/blob/master/t/node/healthcheck-stop-checker.t
yes,i hava add some test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #8493: fix: etcd data sync exception
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander commented on PR #8493:
URL: https://github.com/apache/apisix/pull/8493#issuecomment-1459118565
Since people keep asking about it, we can merge it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jobop commented on a diff in pull request #8493: fix: etcd data sync exception
Posted by GitBox <gi...@apache.org>.
jobop commented on code in PR #8493:
URL: https://github.com/apache/apisix/pull/8493#discussion_r1044944757
##########
apisix/core/config_util.lua:
##########
@@ -96,6 +96,10 @@ end
-- fire all clean handlers added by add_clean_handler.
function _M.fire_all_clean_handlers(item)
+ -- When the key is deleted, the item will be set to false.
Review Comment:
When the key is deleted, the item will be set to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zhangliweixyz commented on pull request #8493: fix: etcd data sync exception
Posted by GitBox <gi...@apache.org>.
zhangliweixyz commented on PR #8493:
URL: https://github.com/apache/apisix/pull/8493#issuecomment-1354147831
Hi, I had the same problem, and Is there any way to solve this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #8493: fix: etcd data sync exception
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander merged PR #8493:
URL: https://github.com/apache/apisix/pull/8493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] basuotian commented on pull request #8493: fix: etcd data sync exception
Posted by "basuotian (via GitHub)" <gi...@apache.org>.
basuotian commented on PR #8493:
URL: https://github.com/apache/apisix/pull/8493#issuecomment-1449391216
we had the same problem, it occur especially in etcd_auto_compaction_mode=revision during we do a lot of update/delete operation to apisixroute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] oyiadin commented on pull request #8493: fix: etcd data sync exception
Posted by "oyiadin (via GitHub)" <gi...@apache.org>.
oyiadin commented on PR #8493:
URL: https://github.com/apache/apisix/pull/8493#issuecomment-1475250066
maybe related: https://github.com/apache/apisix/issues/8648#issuecomment-1475240703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #8493: fix: etcd data sync exception
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #8493:
URL: https://github.com/apache/apisix/pull/8493#discussion_r1046695234
##########
t/core/config_util.t:
##########
@@ -103,6 +108,9 @@ __DATA__
local item, idx1, idx2 = setup()
util.cancel_clean_handler(item, idx1)
util.fire_all_clean_handlers(item)
+
+ local item = setup_to_false()
+ util.fire_all_clean_handlers(item)
Review Comment:
Is it possible to test this bug by deleting a key as you described in the issue? It would be great if we could cover it via an integration test which is more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #8493: fix: etcd data sync exception
Posted by GitBox <gi...@apache.org>.
spacewander commented on PR #8493:
URL: https://github.com/apache/apisix/pull/8493#issuecomment-1357123483
@zhangliweixyz
Let's wait for @jobop to update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zsmlinux commented on pull request #8493: fix: etcd data sync exception
Posted by "zsmlinux (via GitHub)" <gi...@apache.org>.
zsmlinux commented on PR #8493:
URL: https://github.com/apache/apisix/pull/8493#issuecomment-1453234539
How about this bug now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jobop commented on pull request #8493: fix: etcd data sync exception
Posted by GitBox <gi...@apache.org>.
jobop commented on PR #8493:
URL: https://github.com/apache/apisix/pull/8493#issuecomment-1346692559
>
yes,i hava add some test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org