You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2023/10/19 20:40:52 UTC
[PR] SOLR-17042: Remove V2RequestSupport interface [solr]
gerlowskija opened a new pull request, #2028:
URL: https://github.com/apache/solr/pull/2028
https://issues.apache.org/jira/browse/SOLR-17042
# Description
Initially intended as a way to allow dog-fooding of v2 APIs by converting v1 requests into their v2 counterparts, V2RequestSupport never received the adoption it needed to get traction within the codebase. It made most sense in a world where all v2 APIs had clear v1 counterparts, and was only ever implemented for a small set of "collection admin" APIs at the peak of its adoption.
It currently has 0 implementations and should be removed from Solr, as it's largely been superceded by the newer approach of generating distinct v2 SolrRequest implementations from our OAS.
# Solution
This commit removes the V2RequestSupport interface and two associated SolrRequest methods on the `main` branch. (Upon merging, a corresponding set of deprecation notices will be added to `branch_9x` to keep this in line with our backcompat policy.)
# Tests
Existing tests continue to pass.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17042: Remove V2RequestSupport interface [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #2028:
URL: https://github.com/apache/solr/pull/2028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17042: Remove V2RequestSupport interface [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2028:
URL: https://github.com/apache/solr/pull/2028#issuecomment-1771801899
Nice bit of clean up. Makes me sad we can't just remove it altogether if no api's are currently using it....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17042: Remove V2RequestSupport interface [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #2028:
URL: https://github.com/apache/solr/pull/2028#issuecomment-1772856920
> Makes me sad we can't just remove it altogether if no api's are currently using it....
Yeah, agreed. But the cost is pretty low, so it's not a huge deal either way 🤷
This is the first of a few improvements I have in mind to how SolrJ inspects and decides how to route requests. Obviously there'll be a gap between 9.x and 10 for backcompat, but the cumulative effect on `main` is gonna be really nice I hope. Pretty excited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org