You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/29 02:56:38 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #38041: [SPARK-40605][CONNECT] Change to use `log4j2.properties` to configure test log output
LuciferYang opened a new pull request, #38041:
URL: https://github.com/apache/spark/pull/38041
### What changes were proposed in this pull request?
This pr make `connect` module change to use to use `log4j2.properties` to configure test log output as others modules.
### Why are the changes needed?
You should use `log4j2.properties` to configure logs
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #38041: [SPARK-40605][CONNECT] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #38041:
URL: https://github.com/apache/spark/pull/38041#discussion_r983262312
##########
connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:
##########
@@ -58,11 +58,6 @@ class SparkConnectPlannerSuite extends SparkFunSuite with SparkConnectPlanTest {
protected var spark: SparkSession = null
- override def beforeAll(): Unit = {
- super.beforeAll()
- TestUtils.configTestLog4j2("INFO")
Review Comment:
Not limited to the `connect` module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38041: [SPARK-40605][CONNECT][TESTS] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38041:
URL: https://github.com/apache/spark/pull/38041#issuecomment-1263046585
thank @HyukjinKwon @wangyum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38041: [SPARK-40605][CONNECT] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38041:
URL: https://github.com/apache/spark/pull/38041#issuecomment-1261970526
Yeah, let's keep it under [SPARK-39375](https://issues.apache.org/jira/browse/SPARK-39375)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #38041: [SPARK-40605][CONNECT] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #38041:
URL: https://github.com/apache/spark/pull/38041#discussion_r983019642
##########
connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:
##########
@@ -58,11 +58,6 @@ class SparkConnectPlannerSuite extends SparkFunSuite with SparkConnectPlanTest {
protected var spark: SparkSession = null
- override def beforeAll(): Unit = {
- super.beforeAll()
- TestUtils.configTestLog4j2("INFO")
Review Comment:
`TestUtils.configTestLog4j2` always print log to console, some noises. I So I think it is better not to use this method unless debugging for something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38041: [SPARK-40605][CONNECT][TESTS] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38041:
URL: https://github.com/apache/spark/pull/38041#issuecomment-1263046474
@amaliujia Yes, you are right:
```
[INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ spark-connect_2.12 ---
[INFO] org.apache.spark:spark-connect_2.12:jar:3.4.0-SNAPSHOT
[INFO] +- org.apache.spark:spark-core_2.12:jar:3.4.0-SNAPSHOT:provided
[INFO] | +- org.apache.avro:avro:jar:1.11.1:compile
[INFO] | | +- com.fasterxml.jackson.core:jackson-core:jar:2.13.4:compile
[INFO] | | \- org.apache.commons:commons-compress:jar:1.21:compile
[INFO] | +- org.apache.avro:avro-mapred:jar:1.11.1:compile
[INFO] | | \- org.apache.avro:avro-ipc:jar:1.11.1:compile
[INFO] | | \- org.tukaani:xz:jar:1.8:compile
[INFO] | +- com.twitter:chill_2.12:jar:0.10.0:provided
[INFO] | | \- com.esotericsoftware:kryo-shaded:jar:4.0.2:provided
[INFO] | | \- com.esotericsoftware:minlog:jar:1.3.0:provided
[INFO] | +- com.twitter:chill-java:jar:0.10.0:provided
[INFO] | +- org.apache.xbean:xbean-asm9-shaded:jar:4.21:provided
[INFO] | +- org.apache.hadoop:hadoop-client-api:jar:3.3.4:compile
[INFO] | +- org.apache.hadoop:hadoop-client-runtime:jar:3.3.4:compile
[INFO] | | \- commons-logging:commons-logging:jar:1.1.3:runtime
[INFO] | +- org.apache.spark:spark-launcher_2.12:jar:3.4.0-SNAPSHOT:provided
[INFO] | +- org.apache.spark:spark-kvstore_2.12:jar:3.4.0-SNAPSHOT:provided
[INFO] | | +- org.fusesource.leveldbjni:leveldbjni-all:jar:1.8:provided
[INFO] | | \- com.fasterxml.jackson.core:jackson-annotations:jar:2.13.4:compile
[INFO] | +- org.apache.spark:spark-network-common_2.12:jar:3.4.0-SNAPSHOT:provided
[INFO] | | \- com.google.crypto.tink:tink:jar:1.7.0:provided
[INFO] | +- org.apache.spark:spark-network-shuffle_2.12:jar:3.4.0-SNAPSHOT:provided
[INFO] | +- org.apache.spark:spark-unsafe_2.12:jar:3.4.0-SNAPSHOT:provided
[INFO] | +- javax.activation:activation:jar:1.1.1:compile
[INFO] | +- org.apache.curator:curator-recipes:jar:2.13.0:compile
[INFO] | | \- org.apache.curator:curator-framework:jar:2.13.0:compile
[INFO] | | \- org.apache.curator:curator-client:jar:2.13.0:compile
[INFO] | +- org.apache.zookeeper:zookeeper:jar:3.6.2:compile
[INFO] | | +- commons-lang:commons-lang:jar:2.6:compile
[INFO] | | +- org.apache.zookeeper:zookeeper-jute:jar:3.6.2:compile
[INFO] | | \- org.apache.yetus:audience-annotations:jar:0.5.0:compile
[INFO] | +- jakarta.servlet:jakarta.servlet-api:jar:4.0.3:provided
[INFO] | +- commons-codec:commons-codec:jar:1.15:provided
[INFO] | +- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] | +- org.apache.commons:commons-math3:jar:3.6.1:provided
[INFO] | +- org.apache.commons:commons-text:jar:1.9:provided
[INFO] | +- commons-io:commons-io:jar:2.11.0:provided
[INFO] | +- commons-collections:commons-collections:jar:3.2.2:provided
[INFO] | +- org.apache.commons:commons-collections4:jar:4.4:provided
[INFO] | +- com.google.code.findbugs:jsr305:jar:3.0.0:compile
[INFO] | +- org.slf4j:slf4j-api:jar:1.7.36:compile
[INFO] | +- org.slf4j:jul-to-slf4j:jar:1.7.36:provided
[INFO] | +- org.slf4j:jcl-over-slf4j:jar:1.7.36:provided
[INFO] | +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.19.0:compile
[INFO] | +- org.apache.logging.log4j:log4j-api:jar:2.19.0:compile
[INFO] | +- org.apache.logging.log4j:log4j-core:jar:2.19.0:runtime
[INFO] | +- org.apache.logging.log4j:log4j-1.2-api:jar:2.19.0:compile
[INFO] | +- com.ning:compress-lzf:jar:1.1:provided
[INFO] | +- org.xerial.snappy:snappy-java:jar:1.1.8.4:compile
[INFO] | +- org.lz4:lz4-java:jar:1.8.0:provided
[INFO] | +- com.github.luben:zstd-jni:jar:1.5.2-4:compile
[INFO] | +- org.roaringbitmap:RoaringBitmap:jar:0.9.32:provided
[INFO] | | \- org.roaringbitmap:shims:jar:0.9.32:provided
[INFO] | +- org.scala-lang.modules:scala-xml_2.12:jar:2.1.0:provided
[INFO] | +- org.scala-lang:scala-library:jar:2.12.17:provided
[INFO] | +- org.scala-lang:scala-reflect:jar:2.12.17:provided
[INFO] | +- org.json4s:json4s-jackson_2.12:jar:3.7.0-M11:provided
[INFO] | | \- org.json4s:json4s-core_2.12:jar:3.7.0-M11:provided
[INFO] | | +- org.json4s:json4s-ast_2.12:jar:3.7.0-M11:provided
[INFO] | | \- org.json4s:json4s-scalap_2.12:jar:3.7.0-M11:provided
[INFO] | +- org.glassfish.jersey.core:jersey-client:jar:2.36:provided
[INFO] | | +- jakarta.ws.rs:jakarta.ws.rs-api:jar:2.1.6:provided
[INFO] | | \- org.glassfish.hk2.external:jakarta.inject:jar:2.6.1:provided
[INFO] | +- org.glassfish.jersey.core:jersey-common:jar:2.36:provided
[INFO] | | +- jakarta.annotation:jakarta.annotation-api:jar:1.3.5:provided
[INFO] | | \- org.glassfish.hk2:osgi-resource-locator:jar:1.0.3:provided
[INFO] | +- org.glassfish.jersey.core:jersey-server:jar:2.36:provided
[INFO] | | \- jakarta.validation:jakarta.validation-api:jar:2.0.2:provided
[INFO] | +- org.glassfish.jersey.containers:jersey-container-servlet:jar:2.36:provided
[INFO] | +- org.glassfish.jersey.containers:jersey-container-servlet-core:jar:2.36:provided
[INFO] | +- org.glassfish.jersey.inject:jersey-hk2:jar:2.36:provided
[INFO] | | +- org.glassfish.hk2:hk2-locator:jar:2.6.1:provided
[INFO] | | | +- org.glassfish.hk2.external:aopalliance-repackaged:jar:2.6.1:provided
[INFO] | | | +- org.glassfish.hk2:hk2-api:jar:2.6.1:provided
[INFO] | | | \- org.glassfish.hk2:hk2-utils:jar:2.6.1:provided
[INFO] | | \- org.javassist:javassist:jar:3.25.0-GA:provided
[INFO] | +- io.netty:netty-all:jar:4.1.80.Final:provided
[INFO] | | +- io.netty:netty-buffer:jar:4.1.80.Final:provided
[INFO] | | +- io.netty:netty-codec:jar:4.1.80.Final:provided
[INFO] | | +- io.netty:netty-common:jar:4.1.80.Final:provided
[INFO] | | +- io.netty:netty-handler:jar:4.1.80.Final:provided
[INFO] | | +- io.netty:netty-transport-native-unix-common:jar:4.1.80.Final:provided
[INFO] | | +- io.netty:netty-resolver:jar:4.1.80.Final:provided
[INFO] | | +- io.netty:netty-transport:jar:4.1.80.Final:provided
[INFO] | | +- io.netty:netty-transport-classes-epoll:jar:4.1.80.Final:provided
[INFO] | | \- io.netty:netty-transport-classes-kqueue:jar:4.1.80.Final:provided
[INFO] | +- io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.80.Final:provided
[INFO] | +- io.netty:netty-transport-native-epoll:jar:linux-aarch_64:4.1.80.Final:provided
[INFO] | +- io.netty:netty-transport-native-kqueue:jar:osx-aarch_64:4.1.80.Final:provided
[INFO] | +- io.netty:netty-transport-native-kqueue:jar:osx-x86_64:4.1.80.Final:provided
[INFO] | +- io.netty:netty-tcnative-classes:jar:2.0.54.Final:provided
[INFO] | +- com.clearspring.analytics:stream:jar:2.9.6:provided
[INFO] | +- io.dropwizard.metrics:metrics-core:jar:4.2.10:provided
[INFO] | +- io.dropwizard.metrics:metrics-jvm:jar:4.2.10:provided
[INFO] | +- io.dropwizard.metrics:metrics-json:jar:4.2.10:provided
[INFO] | +- io.dropwizard.metrics:metrics-graphite:jar:4.2.10:provided
[INFO] | +- io.dropwizard.metrics:metrics-jmx:jar:4.2.10:provided
[INFO] | +- com.fasterxml.jackson.core:jackson-databind:jar:2.13.4:compile
[INFO] | +- com.fasterxml.jackson.module:jackson-module-scala_2.12:jar:2.13.4:provided
[INFO] | | \- com.thoughtworks.paranamer:paranamer:jar:2.8:provided
[INFO] | +- org.apache.ivy:ivy:jar:2.5.0:provided
[INFO] | +- oro:oro:jar:2.0.8:provided
[INFO] | +- net.razorvine:pickle:jar:1.2:provided
[INFO] | +- net.sf.py4j:py4j:jar:0.10.9.7:provided
[INFO] | \- org.apache.commons:commons-crypto:jar:1.1.0:provided
[INFO] +- org.apache.spark:spark-core_2.12:test-jar:tests:3.4.0-SNAPSHOT:test
[INFO] +- org.apache.spark:spark-catalyst_2.12:jar:3.4.0-SNAPSHOT:provided
[INFO] | +- org.scala-lang.modules:scala-parser-combinators_2.12:jar:1.1.2:provided
[INFO] | +- org.apache.spark:spark-sketch_2.12:jar:3.4.0-SNAPSHOT:provided
[INFO] | +- org.codehaus.janino:janino:jar:3.1.7:provided
[INFO] | +- org.codehaus.janino:commons-compiler:jar:3.1.7:provided
[INFO] | +- org.antlr:antlr4-runtime:jar:4.9.3:provided
[INFO] | +- com.univocity:univocity-parsers:jar:2.9.1:provided
[INFO] | +- org.apache.arrow:arrow-vector:jar:9.0.0:provided
[INFO] | | +- org.apache.arrow:arrow-format:jar:9.0.0:provided
[INFO] | | +- org.apache.arrow:arrow-memory-core:jar:9.0.0:provided
[INFO] | | +- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.13.4:provided
[INFO] | | \- com.google.flatbuffers:flatbuffers-java:jar:1.12.0:provided
[INFO] | \- org.apache.arrow:arrow-memory-netty:jar:9.0.0:provided
[INFO] +- org.apache.spark:spark-sql_2.12:jar:3.4.0-SNAPSHOT:provided
[INFO] | +- org.rocksdb:rocksdbjni:jar:7.6.0:provided
[INFO] | +- org.apache.orc:orc-core:jar:shaded-protobuf:1.8.0:compile
[INFO] | | +- org.apache.orc:orc-shims:jar:1.8.0:compile
[INFO] | | +- io.airlift:aircompressor:jar:0.21:compile
[INFO] | | +- org.jetbrains:annotations:jar:17.0.0:compile
[INFO] | | \- org.threeten:threeten-extra:jar:1.7.1:compile
[INFO] | +- org.apache.orc:orc-mapreduce:jar:shaded-protobuf:1.8.0:compile
[INFO] | +- org.apache.hive:hive-storage-api:jar:2.7.3:compile
[INFO] | +- org.apache.parquet:parquet-column:jar:1.12.3:compile
[INFO] | | +- org.apache.parquet:parquet-common:jar:1.12.3:compile
[INFO] | | \- org.apache.parquet:parquet-encoding:jar:1.12.3:compile
[INFO] | \- org.apache.parquet:parquet-hadoop:jar:1.12.3:compile
[INFO] | +- org.apache.parquet:parquet-format-structures:jar:1.12.3:compile
[INFO] | \- org.apache.parquet:parquet-jackson:jar:1.12.3:runtime
[INFO] +- org.apache.spark:spark-catalyst_2.12:test-jar:tests:3.4.0-SNAPSHOT:test
[INFO] +- org.apache.spark:spark-sql_2.12:test-jar:tests:3.4.0-SNAPSHOT:test
[INFO] +- org.apache.spark:spark-tags_2.12:jar:3.4.0-SNAPSHOT:provided
[INFO] +- com.google.guava:guava:jar:31.0.1-jre:compile
[INFO] | +- com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
[INFO] | +- org.checkerframework:checker-qual:jar:3.12.0:compile
[INFO] | +- com.google.errorprone:error_prone_annotations:jar:2.7.1:compile
[INFO] | \- com.google.j2objc:j2objc-annotations:jar:1.3:compile
[INFO] +- com.google.guava:failureaccess:jar:1.0.1:compile
[INFO] +- com.google.protobuf:protobuf-java:jar:3.21.1:compile
[INFO] +- io.grpc:grpc-netty-shaded:jar:1.47.0:compile
[INFO] | +- io.perfmark:perfmark-api:jar:0.25.0:runtime
[INFO] | \- io.grpc:grpc-core:jar:1.47.0:compile (version selected from constraint [1.47.0,1.47.0])
[INFO] | +- com.google.code.gson:gson:jar:2.9.0:runtime
[INFO] | +- com.google.android:annotations:jar:4.1.1.4:runtime
[INFO] | \- org.codehaus.mojo:animal-sniffer-annotations:jar:1.19:runtime
[INFO] +- io.grpc:grpc-protobuf:jar:1.47.0:compile
[INFO] | +- io.grpc:grpc-api:jar:1.47.0:compile
[INFO] | | \- io.grpc:grpc-context:jar:1.47.0:compile
[INFO] | +- com.google.api.grpc:proto-google-common-protos:jar:2.0.1:compile
[INFO] | \- io.grpc:grpc-protobuf-lite:jar:1.47.0:compile
[INFO] +- io.grpc:grpc-services:jar:1.47.0:compile
[INFO] | \- com.google.protobuf:protobuf-java-util:jar:3.19.2:runtime
[INFO] +- io.grpc:grpc-stub:jar:1.47.0:compile
[INFO] +- org.apache.tomcat:annotations-api:jar:6.0.53:provided
[INFO] +- org.scalacheck:scalacheck_2.12:jar:1.16.0:test
[INFO] | \- org.scala-sbt:test-interface:jar:1.0:test
[INFO] +- org.mockito:mockito-core:jar:4.6.1:test
[INFO] | +- net.bytebuddy:byte-buddy:jar:1.12.10:test
[INFO] | +- net.bytebuddy:byte-buddy-agent:jar:1.12.10:test
[INFO] | \- org.objenesis:objenesis:jar:3.2:provided
[INFO] +- org.spark-project.spark:unused:jar:1.0.0:compile
[INFO] +- org.scalatest:scalatest_2.12:jar:3.2.13:test
[INFO] | +- org.scalatest:scalatest-core_2.12:jar:3.2.13:test
[INFO] | | +- org.scalatest:scalatest-compatible:jar:3.2.13:test
[INFO] | | \- org.scalactic:scalactic_2.12:jar:3.2.13:test
[INFO] | +- org.scalatest:scalatest-featurespec_2.12:jar:3.2.13:test
[INFO] | +- org.scalatest:scalatest-flatspec_2.12:jar:3.2.13:test
[INFO] | +- org.scalatest:scalatest-freespec_2.12:jar:3.2.13:test
[INFO] | +- org.scalatest:scalatest-funsuite_2.12:jar:3.2.13:test
[INFO] | +- org.scalatest:scalatest-funspec_2.12:jar:3.2.13:test
[INFO] | +- org.scalatest:scalatest-propspec_2.12:jar:3.2.13:test
[INFO] | +- org.scalatest:scalatest-refspec_2.12:jar:3.2.13:test
[INFO] | +- org.scalatest:scalatest-wordspec_2.12:jar:3.2.13:test
[INFO] | +- org.scalatest:scalatest-diagrams_2.12:jar:3.2.13:test
[INFO] | +- org.scalatest:scalatest-matchers-core_2.12:jar:3.2.13:test
[INFO] | +- org.scalatest:scalatest-shouldmatchers_2.12:jar:3.2.13:test
[INFO] | \- org.scalatest:scalatest-mustmatchers_2.12:jar:3.2.13:test
[INFO] +- org.scalatestplus:scalacheck-1-16_2.12:jar:3.2.13.0:test
[INFO] +- org.scalatestplus:mockito-4-6_2.12:jar:3.2.13.0:test
[INFO] +- org.scalatestplus:selenium-4-2_2.12:jar:3.2.13.0:test
[INFO] | +- org.seleniumhq.selenium:selenium-java:jar:4.2.2:test
[INFO] | | +- org.seleniumhq.selenium:selenium-api:jar:4.2.2:test
[INFO] | | +- org.seleniumhq.selenium:selenium-chrome-driver:jar:4.2.2:test
[INFO] | | | +- org.seleniumhq.selenium:selenium-chromium-driver:jar:4.2.2:test
[INFO] | | | \- org.seleniumhq.selenium:selenium-json:jar:4.2.2:test
[INFO] | | +- org.seleniumhq.selenium:selenium-devtools-v100:jar:4.2.2:test
[INFO] | | +- org.seleniumhq.selenium:selenium-devtools-v101:jar:4.2.2:test
[INFO] | | +- org.seleniumhq.selenium:selenium-devtools-v102:jar:4.2.2:test
[INFO] | | +- org.seleniumhq.selenium:selenium-devtools-v85:jar:4.2.2:test
[INFO] | | +- org.seleniumhq.selenium:selenium-edge-driver:jar:4.2.2:test
[INFO] | | +- org.seleniumhq.selenium:selenium-firefox-driver:jar:4.2.2:test
[INFO] | | +- org.seleniumhq.selenium:selenium-ie-driver:jar:4.2.2:test
[INFO] | | +- org.seleniumhq.selenium:selenium-opera-driver:jar:4.2.2:test
[INFO] | | +- org.seleniumhq.selenium:selenium-remote-driver:jar:4.2.2:test
[INFO] | | | +- com.beust:jcommander:jar:1.82:test
[INFO] | | | +- io.opentelemetry:opentelemetry-api:jar:1.14.0:test
[INFO] | | | +- io.opentelemetry:opentelemetry-context:jar:1.14.0:test
[INFO] | | | +- io.opentelemetry:opentelemetry-exporter-logging:jar:1.14.0:test
[INFO] | | | | +- io.opentelemetry:opentelemetry-sdk-metrics:jar:1.14.0:test
[INFO] | | | | \- io.opentelemetry:opentelemetry-sdk-logs:jar:1.14.0-alpha:test
[INFO] | | | +- io.opentelemetry:opentelemetry-sdk-common:jar:1.14.0:test
[INFO] | | | +- io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi:jar:1.14.0:test
[INFO] | | | +- io.opentelemetry:opentelemetry-sdk-extension-autoconfigure:jar:1.14.0-alpha:test
[INFO] | | | +- io.opentelemetry:opentelemetry-sdk-trace:jar:1.14.0:test
[INFO] | | | +- io.opentelemetry:opentelemetry-sdk:jar:1.14.0:test
[INFO] | | | +- io.opentelemetry:opentelemetry-semconv:jar:1.14.0-alpha:test
[INFO] | | | +- io.ous:jtoml:jar:2.0.0:test
[INFO] | | | +- org.apache.commons:commons-exec:jar:1.3:test
[INFO] | | | +- org.asynchttpclient:async-http-client:jar:2.12.3:test
[INFO] | | | | +- org.asynchttpclient:async-http-client-netty-utils:jar:2.12.3:test
[INFO] | | | | +- org.reactivestreams:reactive-streams:jar:1.0.3:test
[INFO] | | | | +- com.typesafe.netty:netty-reactive-streams:jar:2.0.4:test
[INFO] | | | | \- com.sun.activation:jakarta.activation:jar:1.2.2:test
[INFO] | | | \- org.seleniumhq.selenium:selenium-http:jar:4.2.2:test
[INFO] | | | \- dev.failsafe:failsafe:jar:3.2.4:test
[INFO] | | +- org.seleniumhq.selenium:selenium-safari-driver:jar:4.2.2:test
[INFO] | | \- org.seleniumhq.selenium:selenium-support:jar:4.2.2:test
[INFO] | \- org.seleniumhq.selenium:htmlunit-driver:jar:3.62.0:test
[INFO] | \- net.sourceforge.htmlunit:htmlunit:jar:2.62.0:test
[INFO] | +- xalan:xalan:jar:2.7.2:test
[INFO] | | \- xalan:serializer:jar:2.7.2:test
[INFO] | +- org.apache.httpcomponents:httpmime:jar:4.5.13:test
[INFO] | | \- org.apache.httpcomponents:httpclient:jar:4.5.13:test
[INFO] | | \- org.apache.httpcomponents:httpcore:jar:4.4.14:test
[INFO] | +- net.sourceforge.htmlunit:htmlunit-core-js:jar:2.62.0:test
[INFO] | +- net.sourceforge.htmlunit:neko-htmlunit:jar:2.62.0:test
[INFO] | | \- xerces:xercesImpl:jar:2.12.2:test
[INFO] | | \- xml-apis:xml-apis:jar:1.4.01:test
[INFO] | +- net.sourceforge.htmlunit:htmlunit-cssparser:jar:1.12.0:test
[INFO] | +- commons-net:commons-net:jar:3.8.0:test
[INFO] | +- org.brotli:dec:jar:0.1.2:test
[INFO] | +- com.shapesecurity:salvation2:jar:3.0.0:test
[INFO] | \- org.eclipse.jetty.websocket:websocket-client:jar:9.4.46.v20220331:test
[INFO] | +- org.eclipse.jetty:jetty-client:jar:9.4.48.v20220622:provided
[INFO] | | \- org.eclipse.jetty:jetty-http:jar:9.4.48.v20220622:provided
[INFO] | +- org.eclipse.jetty:jetty-util:jar:9.4.48.v20220622:provided
[INFO] | +- org.eclipse.jetty:jetty-io:jar:9.4.46.v20220331:provided
[INFO] | \- org.eclipse.jetty.websocket:websocket-common:jar:9.4.46.v20220331:test
[INFO] | \- org.eclipse.jetty.websocket:websocket-api:jar:9.4.46.v20220331:test
[INFO] +- junit:junit:jar:4.13.2:test
[INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] \- com.github.sbt:junit-interface:jar:0.13.3:test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38041: [SPARK-40605][CONNECT][TESTS] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38041:
URL: https://github.com/apache/spark/pull/38041#issuecomment-1262662719
I am missing anything that I didn't see a `log4j` dependency for the connect module. What does `connect` get this library?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #38041: [SPARK-40605][CONNECT] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #38041:
URL: https://github.com/apache/spark/pull/38041#discussion_r983020028
##########
connect/src/test/resources/log4j2.properties:
##########
@@ -0,0 +1,39 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Set everything to be logged to the file target/unit-tests.log
+rootLogger.level = info
+rootLogger.appenderRef.file.ref = ${sys:test.appender:-File}
+
+appender.file.type = File
+appender.file.name = File
+appender.file.fileName = target/unit-tests.log
+appender.file.layout.type = PatternLayout
+appender.file.layout.pattern = %d{yy/MM/dd HH:mm:ss.SSS} %t %p %c{1}: %m%n%ex
+
+# Tests that launch java subprocesses can set the "test.appender" system property to
Review Comment:
copy from `core` module, the content after line 28 can also be deleted if it is not needed at present
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38041: [SPARK-40605][CONNECT] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38041:
URL: https://github.com/apache/spark/pull/38041#issuecomment-1261689871
I'm not sure whether this should belong to the subtask of SPARK-39375. If not, please help move it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #38041: [SPARK-40605][CONNECT] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38041:
URL: https://github.com/apache/spark/pull/38041#issuecomment-1261689144
friendly ping @HyukjinKwon @grundprinzip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #38041: [SPARK-40605][CONNECT] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #38041:
URL: https://github.com/apache/spark/pull/38041#discussion_r983262312
##########
connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:
##########
@@ -58,11 +58,6 @@ class SparkConnectPlannerSuite extends SparkFunSuite with SparkConnectPlanTest {
protected var spark: SparkSession = null
- override def beforeAll(): Unit = {
- super.beforeAll()
- TestUtils.configTestLog4j2("INFO")
Review Comment:
Not limited to the `connect` module? This is the only place for `connect` module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #38041: [SPARK-40605][CONNECT] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #38041:
URL: https://github.com/apache/spark/pull/38041#discussion_r983262312
##########
connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:
##########
@@ -58,11 +58,6 @@ class SparkConnectPlannerSuite extends SparkFunSuite with SparkConnectPlanTest {
protected var spark: SparkSession = null
- override def beforeAll(): Unit = {
- super.beforeAll()
- TestUtils.configTestLog4j2("INFO")
Review Comment:
Not limited to the `connect` module? This is the only place for `connect` module now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38041: [SPARK-40605][CONNECT] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38041:
URL: https://github.com/apache/spark/pull/38041#discussion_r983260119
##########
connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:
##########
@@ -58,11 +58,6 @@ class SparkConnectPlannerSuite extends SparkFunSuite with SparkConnectPlanTest {
protected var spark: SparkSession = null
- override def beforeAll(): Unit = {
- super.beforeAll()
- TestUtils.configTestLog4j2("INFO")
Review Comment:
Yeah, I agree. Is this the only place to fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #38041: [SPARK-40605][CONNECT][TESTS] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #38041: [SPARK-40605][CONNECT][TESTS] Change to use `log4j2.properties` to configure test log output
URL: https://github.com/apache/spark/pull/38041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #38041: [SPARK-40605][CONNECT][TESTS] Change to use `log4j2.properties` to configure test log output
Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #38041:
URL: https://github.com/apache/spark/pull/38041#issuecomment-1262493671
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org