[GitHub] [superset] betodealmeida commented on a change in pull request #14111: feat: invalid hostname and password error messages (Redshift)

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #14111:
URL: https://github.com/apache/superset/pull/14111#discussion_r612814755



##########
File path: superset/db_engine_specs/redshift.py
##########
@@ -14,14 +14,60 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+import re
+
+from flask_babel import gettext as __
+
 from superset.db_engine_specs.postgres import PostgresBaseEngineSpec
+from superset.errors import SupersetErrorType
+
+# Regular expressions to catch custom errors
+TEST_CONNECTION_ACCESS_DENIED_REGEX = re.compile(
+    'FATAL:  password authentication failed for user "(?P<username>.*?)"'

Review comment:
       Let's keep this tight, in case the level changes or the whitespace changes (those 2 spaces look suspicious).
   
   ```suggestion
       'password authentication failed for user "(?P<username>.*?)"'
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org