You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/03 08:40:41 UTC

[GitHub] [pinot] ddcprg commented on a change in pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API

ddcprg commented on a change in pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#discussion_r741708400



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentZKMetadata.java
##########
@@ -410,21 +408,4 @@ public TimeUnit getTimeUnit() {
       return null;
     }
   }
-

Review comment:
       This code is deprecated and it doesn't look like is used anywhere in Pinot - I've checked for the string version of the method names in case reflection was used. I don't think projects other than Pinot should be using this class, I've searched in both Trino and Presto and the class doesn't seem to be in use




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org