You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2018/03/23 20:51:25 UTC
Review Request 66258: Added max_duration to `TaskInfo` and new reason
for kill.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66258/
-----------------------------------------------------------
Review request for mesos, Jason Lai and James Peach.
Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725
Repository: mesos
Description
-------
This new field can be used support tasks which have a maximum duration
scheduling requirement. The new reason is added to distinguish from
normal task kills.
Diffs
-----
include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907
include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95
Diff: https://reviews.apache.org/r/66258/diff/1/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 66258: Added `max_completion_time` to `TaskInfo`
and new reason.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66258/
-----------------------------------------------------------
(Updated April 23, 2018, 3:17 p.m.)
Review request for mesos, Jason Lai and James Peach.
Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725
Repository: mesos
Description
-------
This new field can be used support tasks which have a maximum duration
scheduling requirement. The new reason is added to distinguish from
normal task kills.
Diffs (updated)
-----
include/mesos/mesos.proto 9e24d3ea46edc21572e9226e2e76c7d55618db24
include/mesos/v1/mesos.proto 0f3fd8a2608b5edabc21f5fe5df9b70fc0fa8dc2
Diff: https://reviews.apache.org/r/66258/diff/3/
Changes: https://reviews.apache.org/r/66258/diff/2-3/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 66258: Added `max_completion_time` to `TaskInfo`
and new reason.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66258/#review201120
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/mesos.proto
Lines 2109 (patched)
<https://reviews.apache.org/r/66258/#comment282105>
I think that we can phrase this a little more clearly. How about:
```
Maximum duration for task completion. If the task is non-terminal at the end
of this duration, it will fail with the reason `REASON_MAX_COMPLETION_TIME_REACHED`.
Mesos supports this field for executor-less tasks, and tasks that use the Docker or
default executors. It is the executor's responsibility to implement this, so it might
not be supported by all custom executors.
```
- James Peach
On April 8, 2018, 12:51 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66258/
> -----------------------------------------------------------
>
> (Updated April 8, 2018, 12:51 a.m.)
>
>
> Review request for mesos, Jason Lai and James Peach.
>
>
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This new field can be used support tasks which have a maximum duration
> scheduling requirement. The new reason is added to distinguish from
> normal task kills.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907
> include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95
>
>
> Diff: https://reviews.apache.org/r/66258/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 66258: Added `max_completion_time` to `TaskInfo`
and new reason.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66258/
-----------------------------------------------------------
(Updated April 7, 2018, 5:51 p.m.)
Review request for mesos, Jason Lai and James Peach.
Changes
-------
Rename as we discussed.
Summary (updated)
-----------------
Added `max_completion_time` to `TaskInfo` and new reason.
Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725
Repository: mesos
Description
-------
This new field can be used support tasks which have a maximum duration
scheduling requirement. The new reason is added to distinguish from
normal task kills.
Diffs (updated)
-----
include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907
include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95
Diff: https://reviews.apache.org/r/66258/diff/2/
Changes: https://reviews.apache.org/r/66258/diff/1-2/
Testing
-------
Thanks,
Zhitao Li