You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/27 00:38:42 UTC
[GitHub] [beam] terryxian78 opened a new pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
terryxian78 opened a new pull request #12695:
URL: https://github.com/apache/beam/pull/12695
Fixes https://issues.apache.org/jira/browse/BEAM-8758
CC: @suztomo
The changes are:
1. The main purpose of this commit is upgrading spanner library to 1.59.0, but to upgrade it, I need to also upgrade bigtable_client_core to 1.16.0 and other dependencies;
2. Update spanner type parser to be able to recognize NUMERIC.
Note:
1. I have run "/bin/bash sdks/java/build-tools/beam-linkage-check.sh" and confirmed that there is no linkage errors.
2. I have run presubmit job and passed.
./gradlew spotlessApply && ./gradlew checkstyleMain checkstyleTest javadoc spotbugsMain compileJava compileTestJava
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace
--- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87218
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55881
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...6d26c52](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-685148579
Run Java PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87218
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55881
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...a81c5a3](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87218
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55881
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...6d26c52](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
suztomo commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682974537
Run Java_Examples_Dataflow PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on a change in pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on a change in pull request #12695:
URL: https://github.com/apache/beam/pull/12695#discussion_r481475238
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchema.java
##########
@@ -169,7 +169,9 @@ private static Type parseSpannerType(String spannerType) {
if ("DATE".equals(spannerType)) {
return Type.date();
}
-
+ if ("NUMERIC".equals(spannerType)) {
+ return Type.numeric();
+ }
Review comment:
Done! I reverted the change of this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87218
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55881
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...6d26c52](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-685148649
Run Dataflow ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87226
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55889
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...f1c6846](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.96%
=========================================
Files ? 731
Lines ? 87476
Branches ? 0
=========================================
Hits ? 31457
Misses ? 56019
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...f1c6846](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.95%
=========================================
Files ? 722
Lines ? 86433
Branches ? 0
=========================================
Hits ? 31081
Misses ? 55352
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...1bfd478](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-689829063
@chamikaramj, ping...
I've resolved all concerns (no objection on GcpAPISurfaceTest), pls let me know if it is okay to merge? I have another PR which you asked me to do separately, so it would be nice to get this done so I can start that one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on a change in pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
suztomo commented on a change in pull request #12695:
URL: https://github.com/apache/beam/pull/12695#discussion_r479445387
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchema.java
##########
@@ -169,7 +169,9 @@ private static Type parseSpannerType(String spannerType) {
if ("DATE".equals(spannerType)) {
return Type.date();
}
-
+ if ("NUMERIC".equals(spannerType)) {
+ return Type.numeric();
+ }
Review comment:
@terryxian78 Is this new?
##########
File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java
##########
@@ -65,11 +65,13 @@ public void testGcpApiSurface() throws Exception {
classesInPackage("com.google.bigtable.v2"),
classesInPackage("com.google.cloud.bigquery.storage.v1beta1"),
classesInPackage("com.google.cloud.bigtable.config"),
+ classesInPackage("com.google.common.collect"),
Review comment:
You may want to be more specific here. This includes all the classes in Guava's collection, ImmutableList, ImmutableSet, etc. I believe Beam team has intentionally avoided the classes to be exposed as APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-685168368
> I can revisit when open questions are addressed. Thanks.
What open questions did you mean? All questions have been addressed, including ApiSurfaceTest failure, and explanation of why new classes are exposed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-685177015
> Run Java PostCommit
I am assuming that this comment will automatically kicks off postcommit test, I don't need to do anything, right? (this is my first PR, just want to make sure.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-685901890
> Probably worth discussing the API surface updates in the mailing list before merging to confirm that there's no objection. Thanks.
You have asked whether there is objection in dev mailing list and I replied to it. So far no objection. Let me know what else I need to do and how long I should wait for any objection? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on a change in pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on a change in pull request #12695:
URL: https://github.com/apache/beam/pull/12695#discussion_r481471615
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchema.java
##########
@@ -169,7 +169,9 @@ private static Type parseSpannerType(String spannerType) {
if ("DATE".equals(spannerType)) {
return Type.date();
}
-
+ if ("NUMERIC".equals(spannerType)) {
+ return Type.numeric();
+ }
Review comment:
sure. I will make it a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nielm commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
nielm commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-688719636
> @nielm, what is the bug number which @chamikaramj talks about?
[googleapis/java-spanner/issues/410](https://github.com/googleapis/java-spanner/issues/410)
There is a separate discussion in this bug that the suggested PR is not Java 1.7 compatible (due Future), and that it is a breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
suztomo commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-684062355
Run Python Precommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on a change in pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on a change in pull request #12695:
URL: https://github.com/apache/beam/pull/12695#discussion_r480347768
##########
File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java
##########
@@ -65,11 +65,13 @@ public void testGcpApiSurface() throws Exception {
classesInPackage("com.google.bigtable.v2"),
classesInPackage("com.google.cloud.bigquery.storage.v1beta1"),
classesInPackage("com.google.cloud.bigtable.config"),
+ classesInPackage("com.google.common.collect"),
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.96%
=========================================
Files ? 731
Lines ? 87476
Branches ? 0
=========================================
Hits ? 31457
Misses ? 56019
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...f1c6846](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a change in pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on a change in pull request #12695:
URL: https://github.com/apache/beam/pull/12695#discussion_r481450580
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchema.java
##########
@@ -169,7 +169,9 @@ private static Type parseSpannerType(String spannerType) {
if ("DATE".equals(spannerType)) {
return Type.date();
}
-
+ if ("NUMERIC".equals(spannerType)) {
+ return Type.numeric();
+ }
Review comment:
Can we move this to a separate PR with tests ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-689853466
Thanks. I'll merge this after post-commits pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nielm edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
nielm edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-688719636
> @nielm, what is the bug number which @chamikaramj talks about?
[googleapis/java-spanner/issues/410](https://github.com/googleapis/java-spanner/issues/410)
There is a separate discussion in that bug that the suggested PR is not Java 1.7 compatible (due Future), and that it is a breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.95%
=========================================
Files ? 722
Lines ? 86433
Branches ? 0
=========================================
Hits ? 31081
Misses ? 55352
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...1bfd478](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.95%
=========================================
Files ? 722
Lines ? 86433
Branches ? 0
=========================================
Hits ? 31081
Misses ? 55352
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...1bfd478](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-689007636
> Usual wait period for votes is three business days so we can do the same here.
>
> BTW @nielm mentioned that he create a bug in the Spanner side for updating the API. May be add a TODO with a link to that to remove new classes from the GcpApiSurfaceTest.java when/if that bug is fixed.
Done, I have added a TODO including Niel's issue number.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87218
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55881
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...6d26c52](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-686616613
> Usual wait period for votes is three business days so we can do the same here.
>
> BTW @nielm mentioned that he create a bug in the Spanner side for updating the API. May be add a TODO with a link to that to remove new classes from the GcpApiSurfaceTest.java when/if that bug is fixed.
@nielm, what is the bug number which @chamikaramj talks about?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-686609317
Usual wait period for votes is three business days so we can do the same here.
BTW @nielm mentioned that he create a bug in the Spanner side for updating the API. May be add a TODO with a link to that to remove new classes from the GcpApiSurfaceTest.java when/if that bug is fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-689853077
Run Java PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-685150185
Sorry, could you please address the open questions regarding API surface ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.95%
=========================================
Files ? 722
Lines ? 86433
Branches ? 0
=========================================
Hits ? 31081
Misses ? 55352
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...1bfd478](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-685175154
Probably worth discussing the API surface updates in the mailing list before merging to confirm that there's no objection. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-689006589
> > @nielm, what is the bug number which @chamikaramj talks about?
>
> [googleapis/java-spanner/issues/410](https://github.com/googleapis/java-spanner/issues/410)
>
> There is a separate discussion in that bug that the suggested PR is not Java 1.7 compatible (due Future), and that it is a breaking change.
Thanks, I have added a TODO including the link.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682142109
> Failed: org.apache.beam.sdk.io.gcp.GcpApiSurfaceTest.testGcpApiSurface
>
> The test ensures Beam does not expose unintended (internal) classes as Beam API.
The failure is https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/13264/testReport/org.apache.beam.sdk.io.gcp/GcpApiSurfaceTest/testGcpApiSurface/
The new spanner library needs to expose some classes in com.google.common.collect and interface com.google.common.base.Function, I will add these to the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
suztomo commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682974287
https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Commit/10003/ says:
```
Error Message
java.lang.RuntimeException: Workflow failed. Causes: The Compute Engine API has not fully initialized. Please try again in a
few minutes., Unable to get machine type information for machine type n1-standard-4 in zone us-central1-a because of
insufficient permissions. Please refer to https://cloud.google.com/dataflow/access-control#creating_jobs and make sure you
have sufficient permissions.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.96%
=========================================
Files ? 731
Lines ? 87476
Branches ? 0
=========================================
Hits ? 31457
Misses ? 56019
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...f1c6846](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87218
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55881
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...4efc91b](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
suztomo commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-681320363
Failed: org.apache.beam.sdk.io.gcp.GcpApiSurfaceTest.testGcpApiSurface
The test ensures Beam does not expose unintended (internal) classes as Beam API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.95%
=========================================
Files ? 722
Lines ? 86433
Branches ? 0
=========================================
Hits ? 31081
Misses ? 55352
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...1bfd478](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87226
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55889
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...a81c5a3](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.95%
=========================================
Files ? 722
Lines ? 86433
Branches ? 0
=========================================
Hits ? 31081
Misses ? 55352
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...1bfd478](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-689904222
Run Java PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-689853251
Run Dataflow ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on a change in pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on a change in pull request #12695:
URL: https://github.com/apache/beam/pull/12695#discussion_r480322287
##########
File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java
##########
@@ -65,11 +65,13 @@ public void testGcpApiSurface() throws Exception {
classesInPackage("com.google.bigtable.v2"),
classesInPackage("com.google.cloud.bigquery.storage.v1beta1"),
classesInPackage("com.google.cloud.bigtable.config"),
+ classesInPackage("com.google.common.collect"),
Review comment:
Ack, I will send another iteration to make it more specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87226
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55889
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...a81c5a3](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87218
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55881
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...6d26c52](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.96%
=========================================
Files ? 731
Lines ? 87476
Branches ? 0
=========================================
Hits ? 31457
Misses ? 56019
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...f1c6846](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj merged pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
chamikaramj merged pull request #12695:
URL: https://github.com/apache/beam/pull/12695
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-685194705
Run Java Precommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on a change in pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on a change in pull request #12695:
URL: https://github.com/apache/beam/pull/12695#discussion_r480321210
##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchema.java
##########
@@ -169,7 +169,9 @@ private static Type parseSpannerType(String spannerType) {
if ("DATE".equals(spannerType)) {
return Type.date();
}
-
+ if ("NUMERIC".equals(spannerType)) {
+ return Type.numeric();
+ }
Review comment:
No, This was included in my original pull request, I explained in the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87218
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55881
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...a81c5a3](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.96%
=========================================
Files ? 731
Lines ? 87476
Branches ? 0
=========================================
Hits ? 31457
Misses ? 56019
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...f1c6846](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
suztomo commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-684062474
Run Typescript Precommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-685901890
> Probably worth discussing the API surface updates in the mailing list before merging to confirm that there's no objection. Thanks.
You have asked whether there is objection in dev mailing list and I replied to it. Let me know what else I need to do and how long I should wait for objection? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-689122663
> Usual wait period for votes is three business days so we can do the same here.
>
> BTW @nielm mentioned that he create a bug in the Spanner side for updating the API. May be add a TODO with a link to that to remove new classes from the GcpApiSurfaceTest.java when/if that bug is fixed.
@chamikaramj It's been over
> Usual wait period for votes is three business days so we can do the same here.
>
> BTW @nielm mentioned that he create a bug in the Spanner side for updating the API. May be add a TODO with a link to that to remove new classes from the GcpApiSurfaceTest.java when/if that bug is fixed.
@chamikaramj , Three business days have passed, no objection in the dev mailing list. Are we good now? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
terryxian78 commented on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-684980958
Hi, @lukecwik, I was suggested by @suztomo to add you as reviewer. Could you review this change, or assign somebody else in committee to review it? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.96%
=========================================
Files ? 731
Lines ? 87476
Branches ? 0
=========================================
Hits ? 31457
Misses ? 56019
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...f1c6846](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87226
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55889
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...a81c5a3](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.92%
=========================================
Files ? 729
Lines ? 87226
Branches ? 0
=========================================
Hits ? 31337
Misses ? 55889
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...a81c5a3](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12695:
URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884
# [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12695 +/- ##
=========================================
Coverage ? 35.95%
=========================================
Files ? 722
Lines ? 86433
Branches ? 0
=========================================
Hits ? 31081
Misses ? 55352
Partials ? 0
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=footer). Last update [1019ef3...6d26c52](https://codecov.io/gh/apache/beam/pull/12695?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org