You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/14 04:56:54 UTC

[GitHub] [skywalking] arugal commented on a change in pull request #4647: Add `java` -> `go2sky` -> `java` e2e test case, and adapt v3 protocol

arugal commented on a change in pull request #4647: Add `java` -> `go2sky` -> `java` e2e test case, and adapt v3 protocol
URL: https://github.com/apache/skywalking/pull/4647#discussion_r407867051
 
 

 ##########
 File path: test/e2e/e2e-test/docker/go/go2sky-e2e/go.sum
 ##########
 @@ -0,0 +1,79 @@
+cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
 
 Review comment:
   > Do we really need this file?
   
   `go.sum` should be kept.
   
   https://golang.org/cmd/go/#hdr-Module_authentication_using_go_sum
   
   > I think you have the go2sky commitid, should have these already, if we run go vendor or something in the CI process.
   
   I depend on `go2sky` with the [pseudo-version](https://golang.org/cmd/go/#hdr-Pseudo_versions), which is actually the same as the `commit-id` effect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services