You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/09/27 19:57:12 UTC

Review Request 52313: GEODE-1940: make the Eclipse and IntelliJ formatters consistent in line wrapping

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52313/
-----------------------------------------------------------

Review request for geode, Jinmei Liao, Jared Stewart, John Blum, Kevin Duling, and William Markito.


Bugs: GEODE-1940
    https://issues.apache.org/jira/browse/GEODE-1940


Repository: geode


Description
-------

This changes the line length maximum to 999 in both to prevent the formatters from wrapping lines.


Diffs
-----

  etc/eclipseFormatterProfile.xml ead2f39 
  etc/intellijIdeaCodeStyle.xml 5b01917 

Diff: https://reviews.apache.org/r/52313/diff/


Testing
-------

Reformatting code in both Eclipse and IntelliJ.


Thanks,

Kirk Lund


Re: Review Request 52313: GEODE-1940: make the Eclipse and IntelliJ formatters consistent in line wrapping

Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52313/#review150608
-----------------------------------------------------------


Ship it!




Ship It!

- Jinmei Liao


On Sept. 27, 2016, 7:57 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52313/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 7:57 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, John Blum, Kevin Duling, and William Markito.
> 
> 
> Bugs: GEODE-1940
>     https://issues.apache.org/jira/browse/GEODE-1940
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This changes the line length maximum to 999 in both to prevent the formatters from wrapping lines.
> 
> 
> Diffs
> -----
> 
>   etc/eclipseFormatterProfile.xml ead2f39 
>   etc/intellijIdeaCodeStyle.xml 5b01917 
> 
> Diff: https://reviews.apache.org/r/52313/diff/
> 
> 
> Testing
> -------
> 
> Reformatting code in both Eclipse and IntelliJ.
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Re: Review Request 52313: GEODE-1940: make the Eclipse and IntelliJ formatters consistent in line wrapping

Posted by Kevin Duling <kd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52313/#review150619
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Duling


On Sept. 27, 2016, 12:57 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52313/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 12:57 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, John Blum, Kevin Duling, and William Markito.
> 
> 
> Bugs: GEODE-1940
>     https://issues.apache.org/jira/browse/GEODE-1940
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This changes the line length maximum to 999 in both to prevent the formatters from wrapping lines.
> 
> 
> Diffs
> -----
> 
>   etc/eclipseFormatterProfile.xml ead2f39 
>   etc/intellijIdeaCodeStyle.xml 5b01917 
> 
> Diff: https://reviews.apache.org/r/52313/diff/
> 
> 
> Testing
> -------
> 
> Reformatting code in both Eclipse and IntelliJ.
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>